Skip to content

fib: shell, added custom pton to remove dependency to net_help#3607

Closed
BytesGalore wants to merge 1 commit intoRIOT-OS:masterfrom
BytesGalore:fib_custom_pton
Closed

fib: shell, added custom pton to remove dependency to net_help#3607
BytesGalore wants to merge 1 commit intoRIOT-OS:masterfrom
BytesGalore:fib_custom_pton

Conversation

@BytesGalore
Copy link
Copy Markdown
Member

Rationale:
added a custom pton conversion function to make the fib independent from the network stack implementations.

Finally this enables remove the deprecated net_help module and closing #3574.

@BytesGalore BytesGalore added Area: network Area: Networking Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Aug 11, 2015
@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 11, 2015

You know that this is exactly what ipv6_addr_from_str() is already implementing?

@OlegHahm
Copy link
Copy Markdown
Member

And why don't we use the inet_pton implementation any more?

@BytesGalore
Copy link
Copy Markdown
Member Author

@authmillenon yes, but I want the fib being independent from the network stack
@OlegHahm to get rid of the net_help dependency

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 11, 2015

@BytesGalore the ipv6_addr module is independent of the network stack.

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm to get rid of the net_help dependency

But why? At least inet_pton seems to be completely independent from any specific network stack. And basically, I'm just confused why started with our own implementation (ipv6_addr_from_str()) in the first place.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 11, 2015

And basically, I'm just confused why started with our own implementation (ipv6_addr_from_str()) in the first place.

It is the same implementation. I just moved it from net_help (a module notoriously unspecific regarding its functionality) and and chose a name that fits our coding conventions. The old inet_pton I kept just for the old network stack.

@BytesGalore
Copy link
Copy Markdown
Member Author

oh, I thought that ng_ prefixed stuff is directly dependant on the gnrc.
I will change it to use the ipv6_addr_from_str() :)

@OlegHahm
Copy link
Copy Markdown
Member

Actually, I think this is either a good reason to make an exception from the naming conventions or make an own inet module, because it should be familiar to every C programmer.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 11, 2015

The idea was to make a POSIX wrapper macro for that, just as with the sockets.

@BytesGalore
Copy link
Copy Markdown
Member Author

@OlegHahm so you suggest to stay at inet_pton right?

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm so you suggest to stay at inet_pton right?

Yes. I see no reason against it.

@BytesGalore
Copy link
Copy Markdown
Member Author

ok, I guess then we can close this PR :)

@OlegHahm
Copy link
Copy Markdown
Member

The idea was to make a POSIX wrapper macro for that, just as with the sockets.

I'm also fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants