cpu: lpc2387: provide periph/* implementations, update to use newlib module.#3530
Merged
haukepetersen merged 10 commits intoRIOT-OS:masterfrom Aug 17, 2015
Merged
cpu: lpc2387: provide periph/* implementations, update to use newlib module.#3530haukepetersen merged 10 commits intoRIOT-OS:masterfrom
haukepetersen merged 10 commits intoRIOT-OS:masterfrom
Conversation
kaspar030
added
Type: enhancement
Member
|
Nice one! Will try to test ASAP with avsextrem and PTTU. Ping me if I forget to do so. |
Contributor
Author
|
@OlegHahm ping |
Member
|
How do I test GPIO? |
Contributor
Author
|
I looked for an unused GPIO pin in the spec sheet and a short cable and connected the pin to +5v for the interrupt tests. for output, use a voltmeter between the pin and ground. (all using tests/periph_gpio). |
Merged
boards/avsextrem/Makefile.features
Outdated
Member
|
GPIO seems to work. |
Contributor
|
Looks good to me, everything I tried did also work (for msba2 and avsextrem). Although it's not 100% clean yet, I think it's a good step in the right direction -> so ACK when Travis is happy. |
haukepetersen
added
the
CI: ready for build
Contributor
|
Travis is failing to stuff related to the old network stack -> so let's wait until #3334 is merged an run Travis again! |
Contributor
Author
|
kaspar030
added
the
State: waiting for other PR
Contributor
Author
|
(accidentaly removed radio_packet_length define, so this PR now depends on #3334) |
Contributor
|
everything depends on #3334 :-) |
Member
|
#3334 is history |
kaspar030
removed
the
State: waiting for other PR
Contributor
Author
|
I had to refactor the arm7 newlib support. Now only lpc2387-based devices are using the newlib module, the only other arm7 board, redbee-econotag, is using the cpu-specific newlibs. @haukepetersen Does your ACK hold? |
Contributor
Author
|
@haukepetersen ping |
Contributor
|
Testing now |
cpu/lpc2387/periph/spi.c
Outdated
(it depends on obsolete gpioint module)
kaspar030
force-pushed
the
update_msba2
branch
from
adeba2b to
5e51bf8
Compare
kaspar030
removed
the
State: waiting for other PR
7 tasks
Contributor
Author
@haukepetersen does your ACK hold? travis is happy... |
Contributor
Author
|
@haukepetersen Don't go to holidays without merging this! ;) |
Contributor
|
Looking good -> ACK and go. |
haukepetersen
added a commit
that referenced
this pull request
Aug 17, 2015
cpu: lpc2387: provide periph/* implementations, update to use newlib module.
Member
|
🙌 |
Contributor
Author
|
nice. Thanks for reviewing! |
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 3, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 5, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 6, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Feb 6, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Apr 15, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Sep 5, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gschorcht
added a commit
to gschorcht/RIOT-Xtensa-ESP
that referenced
this pull request
Sep 5, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
gdoffe
pushed a commit
to gdoffe/RIOT
that referenced
this pull request
Dec 17, 2019
Replaces the special heap command approach of the lpc_common module with a more general heap command approach. Module lpc_common was already removed with PR RIOT-OS#2118. PR RIOT-OS#2118 integrated cpu/lpc_common code in cpu/lpc2387. With PR RIOT-OS#3530 special heap handling for cpu/lpc2387 was replaced by newlib memory management which uses _sbrk_r to allocate chunks from the heap. _sbrk_r uses _sheap and _eheap symbols that are defined in lpc2387.ld and can be used together with mallinfo function for heap statistics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our poor lpc2387-based boards are suffering heavy legacitis. This PR tries to cure them.
It includes GPIO, SPI and UART-implementations for lpc2387 and updates the architecture to our shared newlib module.
Heavily tested on msba2, unfortunately I don't have avsextreme or pttu boards.
This drops legacy cc110x and ltc4150 support.
edit waiting for #3620.