Skip to content

board: limifrog-v1 initial commit#3509

Merged
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
katezilla:LimiFrog-v1
Aug 13, 2015
Merged

board: limifrog-v1 initial commit#3509
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
katezilla:LimiFrog-v1

Conversation

@katezilla
Copy link
Copy Markdown
Contributor

No description provided.

@PeterKietzmann PeterKietzmann added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jul 28, 2015
@PeterKietzmann PeterKietzmann self-assigned this Jul 28, 2015
@katezilla
Copy link
Copy Markdown
Contributor Author

board: Initial Commit for LimiFrog Version 1
Original Issue: #3020 (comment)

@katezilla katezilla changed the title boards: limifrog-v1 initial commit board: limifrog-v1 initial commit Jul 28, 2015
@OlegHahm OlegHahm added the Platform: ARM Platform: This PR/issue effects ARM-based platforms label Jul 28, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FEATURES

@PeterKietzmann
Copy link
Copy Markdown
Member

@katezilla thanks for this PR! There are some open questions which must not be faults, but just my unknowing of details. But in general the PR is in a good shape :-)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being so picky. Could you include the model name here? E.G. " Densitron DD-160128FC-1a OLED display; external pins "

@PeterKietzmann
Copy link
Copy Markdown
Member

@katezilla thanks for addressing some of my comments. Your PR looks great now! There is still the thing about the gpio mapping. Could you please adapt that?
Did you already test some peripherals? In that case, I'd ask for lending me the hardware.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add #define LED_RED_GPIO GPIO(PORT_C,3) here please?

@PeterKietzmann
Copy link
Copy Markdown
Member

Using GPIOs as input and output works. The interrupt handler seems to cause a hard fault. Before spending too much time in searching the error, could someone with a nucleo-l1 board please check if this appears on that board with and without this PR (that also changes cpu/stml1/periph/gpio.c)? Thinking about @haukepetersen ;-) , or who else owns this board?

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Aug 7, 2015

@katezilla great work! I think we are close before merging when the minor comments from today are addressed.
For the protocol: I successfully tested SPI and I2C yesterday. Will check GPIO now

Very nice indeed! Looking forward to see the Limifrog with RIOT on it in action.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Aug 7, 2015

P.S. I own an Nucleo L1, too.

@PeterKietzmann
Copy link
Copy Markdown
Member

Oh, good to know :-) ! If you find a minute you could try with the periph_gpio example, if the interrupt handler causes a hard fault without and with this PR.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Aug 7, 2015

I don't have it with me right now. Can you ping me on Monday?

@PeterKietzmann
Copy link
Copy Markdown
Member

If Hauke haven't checked it until then, I'll do so.

@PeterKietzmann
Copy link
Copy Markdown
Member

@OlegHahm, @haukepetersen this is a reminder to test above described behaviour.

@OlegHahm
Copy link
Copy Markdown
Member

I'm on it.

@haukepetersen
Copy link
Copy Markdown
Contributor

Hej, just looked at the GPIO driver together with @OlegHahm. With our board here, even in- and output does not seem to work with the gpio test app anymore (but this might be caused by the legacy implementation not wanting to work with the test case...). I think debugging the GPIO driver in it's current state does not make too much sense, since it is old legacy code. The nicer option would be to re-implement the GPIO driver in a clean way (as done for the f1/f3/f4).

@PeterKietzmann
Copy link
Copy Markdown
Member

Hm, looking just roughly over the driver, it does not look too bad or different from the other ones that you mentioned (for me). Anyway, would you agree that a new driver implementation is out of scope of this PR? What do you think about using the compat-header-solution in this PR and working on a follow-up PR regarding the driver implementation? If it is @katezilla who will do this, it would be nice if you could lend us your nucleo-l1.

@PeterKietzmann
Copy link
Copy Markdown
Member

You need to adapt the vector table in cpu/stm32f1/vectors.c . Please compare how it was done in #3535.

@PeterKietzmann
Copy link
Copy Markdown
Member

Works :-) . Please squash your commits into two. One should hold changes about the stm32l1 changes (gpio driver and interrupt vector). The other one should contain the porting of the limifrog board. Note that the linkerscript is located in the CPU folder but belongs to the porting of the board. It does not matter in which order the commits appear

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 12, 2015
@katezilla
Copy link
Copy Markdown
Contributor Author

squashed

@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Aug 13, 2015
@PeterKietzmann
Copy link
Copy Markdown
Member

Dammit! Travis complains about some applications. You should add #include "cpu.h" in periph.cpu:23

@PeterKietzmann
Copy link
Copy Markdown
Member

Thanks! Next time please write a short line that comments addressed. Otherwise I'll just see this randomly.

@katezilla
Copy link
Copy Markdown
Contributor Author

added the include :)

@PeterKietzmann
Copy link
Copy Markdown
Member

Happy times, and go

PeterKietzmann added a commit that referenced this pull request Aug 13, 2015
board: limifrog-v1 initial commit
@PeterKietzmann PeterKietzmann merged commit 77ca7a5 into RIOT-OS:master Aug 13, 2015
@katezilla katezilla deleted the LimiFrog-v1 branch October 8, 2015 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants