Skip to content

pkg/libfixmath: Protect svn checkout with a lock#3470

Merged
OlegHahm merged 3 commits intoRIOT-OS:masterfrom
jnohlgard:pr/pkg-flock-checkout
Jul 22, 2015
Merged

pkg/libfixmath: Protect svn checkout with a lock#3470
OlegHahm merged 3 commits intoRIOT-OS:masterfrom
jnohlgard:pr/pkg-flock-checkout

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

Should fix problems on Travis with failing checkouts.

@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Area: build system Area: Build system Impact: major The PR changes a significant part of the code base. It should be reviewed carefully CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components labels Jul 22, 2015
@jnohlgard
Copy link
Copy Markdown
Member Author

Works fine on my Linux system with util-linux 2.26.2.
Needs testing on OSX and FreeBSD (the lockf path, it's not installed on Linux by default).

@jnohlgard
Copy link
Copy Markdown
Member Author

Finally Travis is all green for the first time in a long time!

@jnohlgard
Copy link
Copy Markdown
Member Author

Please prioritize reviewing this PR as it fixes a major problem with Travis testing of all other PRs.

@OlegHahm
Copy link
Copy Markdown
Member

To be honest I'm too lazy to review the scripts, but since Travis is green and only libfixmath is affected: ACK and go!

OlegHahm added a commit that referenced this pull request Jul 22, 2015
pkg/libfixmath: Protect svn checkout with a lock
@OlegHahm OlegHahm merged commit 5813db3 into RIOT-OS:master Jul 22, 2015
@jnohlgard jnohlgard deleted the pr/pkg-flock-checkout branch July 22, 2015 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants