drivers/hdc1000: fix hdc1000_startmeasure function#3124
Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom May 31, 2015
jfischer-no:fix@hdc1000
Merged
drivers/hdc1000: fix hdc1000_startmeasure function#3124jnohlgard merged 1 commit intoRIOT-OS:masterfrom jfischer-no:fix@hdc1000
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
jfischer-no:fix@hdc1000
Conversation
Change i2c_write_bytes to i2c_write_byte because it was seriously wrong at this point.
jfischer-no
added
Type: bug
Member
|
If this worked before it must have been pure luck that the vector happened to contain the right bits... ACK for the change, untested because I don't have the device. |
jnohlgard
added
the
CI: ready for build
Member
|
Travis is fine. I did a brief check of the data sheet to validate the function, all is fine. ACK & go |
jnohlgard
pushed a commit
that referenced
this pull request
May 31, 2015
drivers/hdc1000: fix hdc1000_startmeasure function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change i2c_write_bytes to i2c_write_byte because it was
seriously wrong at this point.