Skip to content

cpu/cortexm: disabled hard floats for M4F CPUs#3112

Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_cortex_fpu
May 30, 2015
Merged

cpu/cortexm: disabled hard floats for M4F CPUs#3112
jnohlgard merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_cortex_fpu

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

Currently, the save/restore of FPU registers for Cortex-M4F CPUs is not implemented (see issue #1366). To make sure we don't run into trouble when using floats on these CPUs, this PR disables the use of the hardware FPU in the first place.

@haukepetersen haukepetersen added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms labels May 29, 2015
@haukepetersen haukepetersen added this to the Release 2015.06 milestone May 29, 2015
@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 29, 2015
@jnohlgard
Copy link
Copy Markdown
Member

Since FP register stacking during context switching will affect the memory usage it might be a good idea to let a project define some variable in its Makefile to enable/disable the FPU usage without having to modify any RIOT code or Makefiles.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

makes sense. But this would IMHO be part of the PR that fixes the FPU usage.

@jnohlgard
Copy link
Copy Markdown
Member

@haukepetersen OK

ACK, go when Travis is green

@OlegHahm
Copy link
Copy Markdown
Member

👍

@jnohlgard
Copy link
Copy Markdown
Member

kicked Travis

@jnohlgard
Copy link
Copy Markdown
Member

Travis is green, go

jnohlgard pushed a commit that referenced this pull request May 30, 2015
cpu/cortexm: disabled hard floats for M4F CPUs
@jnohlgard jnohlgard merged commit 68ee0f7 into RIOT-OS:master May 30, 2015
@haukepetersen haukepetersen deleted the fix_cortex_fpu branch May 30, 2015 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants