drivers/lis3dh: FIFO mode improvements#3054
Conversation
jnohlgard
added
Type: enhancement
|
@gebart I had a look at you changes. I was just wondering why you didn't change the hardware register addresses to macros also (but I don't really mind). Everything looks like an improvement and reasonable to me. I'd give my ACK when someone ran the test with positive result. |
|
@PeterKietzmann I reasoned that the hardware register addresses make up an enumerated list of locations, so I let it remain an Does anyone else have this chip connected to anything other than a Mulle? |
|
@gebart I think you can squash your commits. At least the first and the second one. But the third can be squashed as well I guess. Does anyone have a LIS3DH sensor to test this? Otherwise someone with a Mulle board? |
|
Nobody owns a LIS3DH sensor? |
|
Or does at least anyone has a mulle-board to confirm this improvement? |
jnohlgard
force-pushed
the
pr/lis3dh-fifo
branch
from
8bf5d3c to
43ee33a
Compare
|
Rebased, updated after GPIO init changes |
|
@gebart I will look at the latest commits next week. Then I propose to just merge this PR. |
jnohlgard
added
the
CI: needs squashing
|
ping @PeterKietzmann |
|
Missing ">" here (don't know if the link works. Its in the header file line 19) |
|
Superfluous "@" in lis3dh.h:246 |
There was a problem hiding this comment.
In lis3dh_t you also have int2. I'm wondering (i) why this function is named with a "1" or (ii) why there is not function for int2
There was a problem hiding this comment.
INT1 and INT2 are the signal names for the interrupt pins in the data sheet. I did not implement any INT2 functionality, but I think it is more clear if I call the function _int1 instead of _int since someone might want to implement INT2 in the future.
|
@gebart I think in general I'm fine with this PR. Is this sensor available for anyone in the meantime? |
|
@gebart please squash |
|
squashed |
jnohlgard
removed
the
CI: needs squashing
PeterKietzmann
added
the
CI: ready for build
|
and go |
drivers/lis3dh: FIFO mode improvements
2 participants
This PR is a refactor of the LIS3DH driver to improve the FIFO mode setting API and add support for the INT1 interrupt signal.
I changed some of the enums into macros since they were not exactly used as a list of enumerated values. The names were kept though, so the user code does not need to be modified.
Tested on mulle.