cpu: unified cortex-m[034]_common implementations by haukepetersen · Pull Request #3023 · RIOT-OS/RIOT

haukepetersen · 2015-05-18T16:52:49Z

and the cleanup continues...

EDIT
~~I did not touch all CPUs yet, as I want to wait for #2852 to be merged.~~
#2852 was merged.

Tested with one CPU from each Cortex family, the STM32F0 (M0), SAMD21 (M0+), STM32F1 (M3) STM32F3 & STM32F4 (both M4F).

kaspar030 · 2015-05-18T17:41:43Z

nice one!

jnohlgard · 2015-05-19T04:17:14Z

cpu/cortex-m_common/include/core_cm0.h

Delete this change, you can reapply parts of #3016 to save on manual work.

jnohlgard · 2015-05-19T04:20:38Z

I think this is a step in the right direction for better maintainability.

haukepetersen · 2015-05-19T08:09:30Z

fixed tab issues

haukepetersen · 2015-05-26T18:56:01Z

here we go. This PR should now work for every cortex-based board.

haukepetersen · 2015-05-26T19:46:46Z

EDIT
~~rebased on #3076 and adjusted the saml21-xpro~~

haukepetersen · 2015-05-26T20:59:25Z

rebased again.

haukepetersen · 2015-05-27T17:38:10Z

Could someone test and ack this, @PeterKietzmann, @kaspar030, @gebart, @OlegHahm? Otherwise it's building up a lot of dependecies... Thx!

jnohlgard · 2015-05-27T19:23:51Z

cpu/cortexm_common/include/cpu.h

you could leave the 2014 in there, i.e. 2014-2015

Actually, I think you MUST.

that was new to me. will fix it.

Maybe I was wrong about the MUST, but it seems to be a good idea not to change, but to expand, see http://stackoverflow.com/a/2391555 .

jnohlgard · 2015-05-27T20:04:03Z

Update all the copyrights to include the entire time span in years year-now, e.g. 2014-2015

jnohlgard · 2015-05-27T20:06:48Z

haukepetersen@ba9d259 commit message sepllnig: doxygen

jnohlgard · 2015-05-27T20:50:41Z

I opened a PR at haukepetersen#8 for some minor improvements to the selection of toolchain prefixes. I plan on merging the Clang stuff from Mulle into cortex-m common later, but the PR is just a small preparation to make sure that all platforms follow the same pattern in the Makefile variables.

haukepetersen · 2015-05-27T21:23:56Z

fixed the copyrights, fixed the miss-spelled commit message and merged @gebarts fixes.

jnohlgard · 2015-05-27T22:09:21Z

ACK, please squash, go when Travis is happy.

haukepetersen · 2015-05-28T13:18:07Z

suqashed and rebased. Go Travis, go.

jnohlgard · 2015-05-28T16:52:13Z

Needs rebase...

haukepetersen · 2015-05-28T17:26:16Z

again?! Dammit...

haukepetersen · 2015-05-28T17:29:38Z

rebased.

- removed coretx-m[0|3|4] - moved their content to cortexm_common - adjusted cortex Makefiles to this new name - adjusted cortex Makefiles new structure

- changed naming of cortexm_common in makefiles - included some minor cleanups

GDB can be built as multitarget which can debug multiple architectures and is often installed without a target prefix.

jnohlgard · 2015-05-28T17:31:30Z

I'm running a compile test locally on my machine

jnohlgard · 2015-05-28T20:23:29Z

compile tests went fine on my machine

PeterKietzmann · 2015-05-29T07:05:35Z

ping

jnohlgard · 2015-05-29T07:54:32Z

ACK holds, & go

cpu: unified cortex-m[034]_common implementations

jfischer-no · 2015-05-29T08:41:35Z

🎆

haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels May 18, 2015

haukepetersen assigned kaspar030 May 18, 2015

haukepetersen added this to the Release 2015.06 milestone May 18, 2015

jnohlgard reviewed May 19, 2015
View reviewed changes

haukepetersen force-pushed the opt_cortexm branch from 86c93d0 to e80bbe9 Compare May 19, 2015 08:09

OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 19, 2015

haukepetersen force-pushed the opt_cortexm branch from e80bbe9 to 8d48bec Compare May 26, 2015 18:54

haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2015

haukepetersen force-pushed the opt_cortexm branch from 2df1f07 to 542312a Compare May 26, 2015 19:46

haukepetersen force-pushed the opt_cortexm branch from 542312a to 2d8d279 Compare May 26, 2015 20:59

jnohlgard mentioned this pull request May 26, 2015

pkg/cmsis-dsp: Add CMSIS-DSP as a package #3028

Merged

jnohlgard reviewed May 27, 2015
View reviewed changes

haukepetersen mentioned this pull request May 27, 2015

cpu: centralized cortex initialization and some defines #3100

Merged

haukepetersen force-pushed the opt_cortexm branch from a2c7cf9 to e66de6e Compare May 27, 2015 21:21

haukepetersen mentioned this pull request May 27, 2015

kinetis: adaption for common makefiles #3099

Merged

jfischer-no mentioned this pull request May 27, 2015

cpu: RIOT port for Freescale Kinetis CPUs #2188

Closed

45 tasks

haukepetersen force-pushed the opt_cortexm branch 2 times, most recently from 64b3ce8 to 880c8a4 Compare May 28, 2015 13:17

haukepetersen removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 28, 2015

haukepetersen force-pushed the opt_cortexm branch from 880c8a4 to 42f48b7 Compare May 28, 2015 17:29

haukepetersen and others added 8 commits May 28, 2015 19:30

cpu: unified cortexm_common folder

b8dd144

- removed coretx-m[0|3|4] - moved their content to cortexm_common - adjusted cortex Makefiles to this new name - adjusted cortex Makefiles new structure

boards: moved flashing options to openocd Makefile

97b6c56

boards: adapted Makefiles to cortexm_common folder

49dcb69

- changed naming of cortexm_common in makefiles - included some minor cleanups

cpu: adapted Makefiles to unified cortexm module

0d5c854

cpu/samd21: moved -O0 from board to cpu

38f4fc7

doc: adapted doxygen excludes

26b9e9a

boards: Makefile.include.gnu: Use GDBPREFIX for GDB

02fe7c5

GDB can be built as multitarget which can debug multiple architectures and is often installed without a target prefix.

boards: Let env override PREFIX, set TARGET_TRIPLE

42f48b7

jnohlgard pushed a commit that referenced this pull request May 29, 2015

Merge pull request #3023 from haukepetersen/opt_cortexm

cbe10e1

cpu: unified cortex-m[034]_common implementations

jnohlgard merged commit cbe10e1 into RIOT-OS:master May 29, 2015

haukepetersen deleted the opt_cortexm branch May 29, 2015 08:24

Conversation

haukepetersen commented May 18, 2015

Uh oh!

kaspar030 commented May 18, 2015

Uh oh!

jnohlgard May 19, 2015

Choose a reason for hiding this comment

Uh oh!

jnohlgard commented May 19, 2015

Uh oh!

haukepetersen commented May 19, 2015

Uh oh!

haukepetersen commented May 26, 2015

Uh oh!

haukepetersen commented May 26, 2015

Uh oh!

haukepetersen commented May 26, 2015

Uh oh!

haukepetersen commented May 27, 2015

Uh oh!

jnohlgard May 27, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm May 27, 2015

Choose a reason for hiding this comment

Uh oh!

haukepetersen May 27, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm May 27, 2015

Choose a reason for hiding this comment

Uh oh!

jnohlgard commented May 27, 2015

Uh oh!

jnohlgard commented May 27, 2015

Uh oh!

jnohlgard commented May 27, 2015

Uh oh!

haukepetersen commented May 27, 2015

Uh oh!

jnohlgard commented May 27, 2015

Uh oh!

haukepetersen commented May 28, 2015

Uh oh!

jnohlgard commented May 28, 2015

Uh oh!

haukepetersen commented May 28, 2015

Uh oh!

haukepetersen commented May 28, 2015

Uh oh!

jnohlgard commented May 28, 2015

Uh oh!

jnohlgard commented May 28, 2015

Uh oh!

PeterKietzmann commented May 29, 2015

Uh oh!

jnohlgard commented May 29, 2015

Uh oh!

jfischer-no commented May 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants