sys/auto_init: added mechanism for initialization of network devices#2891
sys/auto_init: added mechanism for initialization of network devices#2891miri64 merged 7 commits intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Area: build system
There was a problem hiding this comment.
Either name this function and the module ng_auto_init_netif or just auto_init_netif. It's worse enough that ng_ has become an infix for MODULE_ macros and net_ doxygen groups. For the future switch-over I'd like to have as few corner-cases as possible. Currently there is (in sed syntax) \<ng_, \<NG_, \<MODULE_NG and \<net_ng.
There was a problem hiding this comment.
but this does syntactical not make sense: the notion is: auto_init_MODULE_NAME, and the module is called ng_netif...
|
αpart from the comments above and the fact, that there is still room for optimization IMHO (as always) I'm fine with this PR. |
|
addressed comments. Should I squash? |
|
Yes, please (This is an ACK, if travis is happy) |
haukepetersen
force-pushed
the
ng_autoinit_netif
branch
from
f5d4aab to
2187b5c
Compare
|
Please address my last two comments also |
|
squashed. Wontfix your last comments as in my opinion they do not hurt and changing the prio would not change anything... |
|
Alright then … re-ACK |
sys/auto_init: added mechanism for initialization of network devices
3 participants
This PR introduces a mechanism, that allows for auto-configuration of network interfaces. The configuration is normally done by each board (of course it is interesting only for those that have network interfaces), but can be overwritten by the application (may you want a different MAC layer...).