cpu: saml21 initial commit by kaspar030 · Pull Request #2849 · RIOT-OS/RIOT

kaspar030 · 2015-04-22T08:34:15Z

basic port, uart, one timer, gpio, spi working.

Needs MCU support patch for openocd. [1]

My work on this port was mostly paid by FreshTemp, LLC. Thanks, guys!

[1] https://www.mail-archive.com/[email protected]/msg07241.html

OlegHahm · 2015-04-22T10:00:57Z

+21,943 −0

Spammer! 😝

kaspar030 · 2015-04-22T10:04:03Z

have to top your codestyle commits somehow! ;)

OlegHahm · 2015-04-22T10:18:54Z

By importing hundreds of vendor headers? j/k

kaspar030 · 2015-04-22T10:33:44Z

Is that an ACK? ;)

OlegHahm · 2015-04-22T10:35:22Z

GitHub does not even allow me to review:

Sorry, we could not display the entire diff because it was too big.

(Best excuse ever...)

kaspar030 · 2015-04-22T13:58:04Z

If I'm the only one with that board, who's gonna review this?

OlegHahm · 2015-04-22T14:07:43Z

Maybe at the Hack'n'ACK someone can review?

haukepetersen · 2015-04-28T16:59:33Z

boards/saml21-xpro/Makefile.include

s/arduino due/saml21-xpro/

haukepetersen · 2015-04-28T18:00:54Z

ok, this PR is a bitch to review (too many large header files). Let's do the following: you fix the few comments I had and show me that the board is working and we merge this PR. Then we can fix any stuff that we find afterwards.

kaspar030 · 2015-04-30T20:57:07Z

accidently rebased
comments addressed

Somehow I can't get the PLL to clock the board with 48MHz. But I've set the speed to 16MHz, can we keep that for now?

haukepetersen · 2015-05-05T10:02:27Z

Fine for now I guess. I have it on my list to look at the PLL stuff, maybe in the end of this week...

kaspar030 · 2015-05-13T08:34:51Z

@haukepetersen ping You've seen this working, right?

OlegHahm · 2015-05-13T08:35:51Z

@haukepetersen has probably still >800 GItHub notifications. No chance to trigger him this way. ;)

haukepetersen · 2015-05-13T09:29:12Z

Yes, I have seen this working. And there are still open comments above :-)

kaspar030 · 2015-05-13T09:39:38Z

@haukepetersen The leds are fine now. Anything else?

kaspar030 · 2015-05-17T07:38:24Z

Hm, follow-up PR's are coming. @OlegHahm, if I give you remote access, would you take a look?

OlegHahm · 2015-05-17T08:26:34Z

Sure - will be difficult to test the leds though. ;)

kaspar030 · 2015-05-18T11:49:33Z

squashed

haukepetersen · 2015-05-18T11:51:41Z

Then lets wait for Travis and merge!

kaspar030 · 2015-05-18T17:57:02Z

actually there's a problem with SPI at 16mhz, works fine with 4mhz. Its weird, because the formula for calculating the baudrate is so simple. I only tested initialization of ng_at86rf212b, maybe something is going too fast at 16mhz... Still I'd like to merge and find a solution an another PR.

jnohlgard · 2015-05-18T19:13:14Z

The at86rf212b is picky with the timings between the bytes as well, not
just the baud rate. Check the data sheet for details on that.
On May 18, 2015 7:57 PM, "Kaspar Schleiser" [email protected]
wrote:

actually there's a problem with SPI at 16mhz, works fine with 4mhz. Its
weird, because the formula for calculating the baudrate is so simple. I
only tested initialization of ng_at86rf212b, maybe something is going too
fast at 16mhz... Still I'd like to merge and find a solution an another PR.

—
Reply to this email directly or view it on GitHub
#2849 (comment).

OlegHahm · 2015-05-19T07:18:22Z

C++ header guards are missing in cpu/saml21/include/atmel/component

kaspar030 · 2015-05-19T07:23:20Z

C++ header guards are missing in cpu/saml21/include/atmel/component

I solved this by putting the #include of the first atmel header within #ifdef C++ in cpu-conf.h.
That way we don't have to change all the headers. They are not supposed to be included by anything other than cpu-conf.h.

OlegHahm · 2015-05-19T07:25:29Z

Maybe you can modify the script, to exclude certain directories from the check? I just want to make sure, that the other Travis scripts are ran and show no errors.

kaspar030 · 2015-05-19T07:25:55Z

I'll take a look...

kaspar030 · 2015-05-19T07:33:38Z

added the atmel dirs to externc's ignore regex

OlegHahm · 2015-05-19T07:36:14Z

Doesn't seem very scalable 😉, but will work for now and is out of scope for thie PR.

kaspar030 · 2015-05-19T08:30:48Z

@gebart Found it, it was spi_transfer_byte not waiting for receive to finish when in==null, causing the CS line to be dropped too early. I wonder why this works in the very similar samr21 implementation...

Will commit in a follow up, I'm tired of rebasing & squashing & waiting again for travis. :)

OlegHahm · 2015-05-21T22:05:31Z

Somehow your last commit keeps on causing Travis to hang. I have no clue why.

OlegHahm · 2015-05-21T22:28:55Z

Runs without problems on my laptop though, apart from

cpu/saml21/syscalls.c:233: style (unreadVariable): Variable 'c' is assigned a value that is never used.

Merge at will.

kaspar030 · 2015-05-22T09:45:46Z

Somehow your last commit keeps on causing Travis to hang. I have no clue why.

seems like cppcheck takes too long on the atmel headers... I'll add an exclude mechanism to cppcheck.

basic port, uart, one timer, gpio, spi working.

kaspar030 · 2015-05-22T09:48:16Z

rebased
exclude atmel headers also from cppcheck

OlegHahm · 2015-05-26T07:40:29Z

cpu/saml21/periph/gpio.c:345: performance (redundantAssignment): Variable 'res' is reassigned a value before the old one has been used.

cpu/saml21/periph/uart.c:90: style (unreadVariable): Variable 'baud_calculated' is assigned a value that is never used.

cpu/saml21/syscalls.c:233: style (unreadVariable): Variable 'c' is assigned a value that is never used.

OlegHahm · 2015-05-26T07:41:06Z

And most applications faill to build.

kaspar030 · 2015-05-26T19:03:00Z

@OlegHahm: adaption to the new THREAD_defines was missing. Compile-test works flawlessly now.

kaspar030 · 2015-05-26T19:03:22Z

We could save travis the work...

kaspar030 · 2015-05-26T19:06:26Z

@OlegHahm The syscalls will be dropped in a follow-up PR.

haukepetersen · 2015-05-26T19:13:51Z

Compile tests work here as well. ACK and go.

cpu: saml21 initial commit

kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Apr 22, 2015

kaspar030 assigned haukepetersen Apr 22, 2015

haukepetersen reviewed Apr 28, 2015
View reviewed changes

boards/saml21-xpro/Makefile.include Outdated

Copy link
Copy Markdown

Contributor

haukepetersen Apr 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/arduino due/saml21-xpro/

OlegHahm modified the milestone: Release 2015.06 Apr 29, 2015

kaspar030 force-pushed the saml21 branch from 38261a8 to 4a90b0e Compare April 30, 2015 20:54

kaspar030 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 18, 2015

kaspar030 added 3 commits May 22, 2015 11:47

cpu: saml21 initial commit

af63254

basic port, uart, one timer, gpio, spi working.

tools: externc: ignore saml21 atmel/ includes

8b59240

dist: tools: cppcheck: exclude saml21 atmel headers from check

622acc7

kaspar030 force-pushed the saml21 branch from 459beaa to 622acc7 Compare May 22, 2015 09:47

cpu: saml21: adapt to new THREAD_ stacksize defines

bd479a5

haukepetersen added a commit that referenced this pull request May 26, 2015

Merge pull request #2849 from kaspar030/saml21

42f3812

cpu: saml21 initial commit

haukepetersen merged commit 42f3812 into RIOT-OS:master May 26, 2015

kaspar030 deleted the saml21 branch February 7, 2017 22:14

Conversation

kaspar030 commented Apr 22, 2015

Uh oh!

OlegHahm commented Apr 22, 2015

Uh oh!

kaspar030 commented Apr 22, 2015

Uh oh!

OlegHahm commented Apr 22, 2015

Uh oh!

kaspar030 commented Apr 22, 2015

Uh oh!

OlegHahm commented Apr 22, 2015

Uh oh!

kaspar030 commented Apr 22, 2015

Uh oh!

OlegHahm commented Apr 22, 2015

Uh oh!

haukepetersen Apr 28, 2015

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Apr 28, 2015

Uh oh!

kaspar030 commented Apr 30, 2015

Uh oh!

haukepetersen commented May 5, 2015

Uh oh!

kaspar030 commented May 13, 2015

Uh oh!

OlegHahm commented May 13, 2015

Uh oh!

haukepetersen commented May 13, 2015

Uh oh!

kaspar030 commented May 13, 2015

Uh oh!

kaspar030 commented May 17, 2015

Uh oh!

OlegHahm commented May 17, 2015

Uh oh!

kaspar030 commented May 18, 2015

Uh oh!

haukepetersen commented May 18, 2015

Uh oh!

kaspar030 commented May 18, 2015

Uh oh!

jnohlgard commented May 18, 2015

Uh oh!

OlegHahm commented May 19, 2015

Uh oh!

kaspar030 commented May 19, 2015

Uh oh!

OlegHahm commented May 19, 2015

Uh oh!

kaspar030 commented May 19, 2015

Uh oh!

kaspar030 commented May 19, 2015

Uh oh!

OlegHahm commented May 19, 2015

Uh oh!

kaspar030 commented May 19, 2015

Uh oh!

OlegHahm commented May 21, 2015

Uh oh!

OlegHahm commented May 21, 2015

Uh oh!

kaspar030 commented May 22, 2015

Uh oh!

kaspar030 commented May 22, 2015

Uh oh!

OlegHahm commented May 26, 2015

Uh oh!

OlegHahm commented May 26, 2015

Uh oh!

kaspar030 commented May 26, 2015

Uh oh!

kaspar030 commented May 26, 2015

Uh oh!

kaspar030 commented May 26, 2015

Uh oh!

haukepetersen commented May 26, 2015

Uh oh!