Skip to content

ipv6_netif: expand interface#2735

Merged
miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64:ipv6_netif/feat/hl
Apr 8, 2015
Merged

ipv6_netif: expand interface#2735
miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64:ipv6_netif/feat/hl

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Mar 29, 2015

Main focus of this PR is to include the current hop limit into the IPv6 interfaces, since the Neighbor discovery expects it to be interface local.

Additionally I piggy-backed some cosmetic changes to the macro definitions:

  • moved default MTU from ng_ipv6.h to ng_ipv6/netif.h. We only need it in this module anyways and this way we keep it independent from the main header (avoidance of cyclic inclusion).
  • added flags for later modules (ng_sixlowpan (ng_sixlowpan: initial import #2614) and ng_ndp ([WIP] ng_ndp: Initial import of router discovery #2612) namely)
  • added ADDR_ to the address flag macros to distinguish them from the newly included flags for ng_ipv6_netif_t itself.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking NSTF labels Mar 29, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Mar 29, 2015
@miri64 miri64 mentioned this pull request Mar 29, 2015
@miri64 miri64 force-pushed the ipv6_netif/feat/hl branch from 261d87c to 900bb7a Compare March 29, 2015 23:20
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 29, 2015

Rebased to current master

@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@miri64 miri64 changed the title ipv6_netif: add hop limit and some cosmetic changes ipv6_netif: add hop limit and flags Apr 7, 2015
@miri64 miri64 changed the title ipv6_netif: add hop limit and flags ipv6_netif: expand interface Apr 7, 2015
@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 8, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Apr 8, 2015

ACK

@miri64 miri64 force-pushed the ipv6_netif/feat/hl branch from 703ff25 to af2ad5c Compare April 8, 2015 08:42
miri64 added 2 commits April 8, 2015 10:43
Since NDP will introduce interface specific flags this naming might get
confusing
@miri64 miri64 force-pushed the ipv6_netif/feat/hl branch from af2ad5c to 25b568e Compare April 8, 2015 08:43
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 8, 2015

"squashed" (reordered the commits to a more logical order and reworded the former [SQUASH ME] commit)

@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 8, 2015
miri64 added a commit that referenced this pull request Apr 8, 2015
@miri64 miri64 merged commit b8fea1a into RIOT-OS:master Apr 8, 2015
@miri64 miri64 deleted the ipv6_netif/feat/hl branch April 8, 2015 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants