Skip to content

ipv6_hdr: Initial import#2731

Merged
miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64:ipv6_hdr/feat/initial
Apr 10, 2015
Merged

ipv6_hdr: Initial import#2731
miri64 merged 4 commits intoRIOT-OS:masterfrom
miri64:ipv6_hdr/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Mar 28, 2015

Taken out of #2454 to be used by other PRs that need this header (e.g. #2430).

Based on #2730 for checksum calculation (merged).

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT NSTF labels Mar 28, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Mar 28, 2015
@miri64 miri64 mentioned this pull request Mar 28, 2015
Merged
Kijewski
Kijewski reviewed Mar 29, 2015
View reviewed changes
Makefile.dep
Copy link
Copy Markdown
Contributor

@Kijewski Kijewski Mar 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally unrelated to this PR: The prefix NG sucks. Whats next? NNG -- "the next new negeration"? After that ENNG "even newer next generation"? UMNGT -- "ultimate mighty next generation thingy"?

Copy link
Copy Markdown
Member Author

@miri64 miri64 Mar 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to remove this prefix as soon as the new stack is stable and the old one can be removed. We did this primarily to keep colisions with the old stack as low as possible. When the network stack is done, there will be a big rename commit and ng_ will be a thing of the past ;-)

This was referenced Mar 29, 2015
Merged
Merged
@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@miri64 miri64 added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable State: waiting for other PR State: The PR requires another PR to be merged first labels Apr 8, 2015
OlegHahm
OlegHahm reviewed Apr 9, 2015
View reviewed changes
sys/include/net/ng_ipv6/hdr.h Outdated
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make sense to paste the complete packet structure from the RFC?

Copy link
Copy Markdown
Member Author

@miri64 miri64 Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Apr 9, 2015

ACK - if comment is addressed, Travis is happy and PR is squashed.

@miri64 miri64 force-pushed the ipv6_hdr/feat/initial branch from 8b12d9e to 7a3c373 Compare April 9, 2015 22:42
@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 9, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Apr 9, 2015

Rebased to current #2730 and squashed.

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 10, 2015
miri64 added a commit that referenced this pull request Apr 10, 2015
@miri64
Merge pull request #2731 from authmillenon/ipv6_hdr/feat/initial
c940945 
ipv6_hdr: Initial import
@miri64 miri64 merged commit c940945 into RIOT-OS:master Apr 10, 2015
@miri64 miri64 deleted the ipv6_hdr/feat/initial branch April 10, 2015 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@haukepetersen haukepetersen

Labels

Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Network Stack Task Force

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @OlegHahm @Kijewski @haukepetersen