drivers: Added support pn532 driver for NFC communication by berbecche · Pull Request #2692 · RIOT-OS/RIOT

berbecche · 2015-03-23T13:52:24Z

This library is for pn532's chips via SPI communication.
Library is developed for your udoo board, you should be able to interactively use any Adafruit PN532 Shield right connected to ICSP header and CS on pin 23. It should work with any SAM3X8E mcu.
It should also work with other boards connected to this device but I haven't tried it out yet due to the lack of time.

OlegHahm · 2015-08-22T09:55:24Z

Does anyone plan to continue to work on this?

thomaseichinger · 2015-08-23T20:36:44Z

Will take a look at it.

thomaseichinger · 2015-08-24T19:31:11Z

@berbecche I'm sorry I missed this one. Could you elaborate why this should only be usable with the sam3x CPU's? Maybe we can get it working with all of RIOT's supported MCUs.

berbecche · 2015-08-24T19:37:37Z

Hi. I'm pretty sure it works with sam3x CPU's because I tested it. I'm not
able to assure this driver works with all RIOT MCUs and I haven't.
Unfortunately, right now, I haven't time to spend to make it works for all
RIOT MCUs.

Il 24/ago/2015 21:31, "Thomas Eichinger" [email protected] ha
scritto:

@berbecche I'm sorry I missed this one. Could you elaborate why this
should only be usable with the sam3x CPU's? Maybe we can get it working
with all of RIOT's supported MCUs.

—
Reply to this email directly or view it on GitHub.

thomaseichinger · 2015-08-24T19:47:25Z

Ok, I will take a look to see what has to be done.

thomaseichinger · 2015-09-01T15:51:07Z

@berbecche I discussed this with other maintainers offline. I will take a look what has to be done to get your code usable by more RIOT supported boards and will open PR against your repo. This is of high value for us so we would then merge it, after some testing, and open an issue to fix styling and debugging messages as a newbie task.
Are you ok if we proceed like this?

berbecche · 2015-09-01T15:57:13Z

Of course. Whatever to make more usable for RIOT.
Regards.

2015-09-01 17:51 GMT+02:00 Thomas Eichinger [email protected]:

@berbecche https://github.com/berbecche I discussed this with other
maintainers offline. I will take a look what has to be done to get your
code usable by more RIOT supported boards and will open PR against your
repo. This is of high value for us so we would then merge it, after some
testing, and open an issue to fix styling and debugging messages as a
newbie task.
Are you ok if we proceed like this?

—
Reply to this email directly or view it on GitHub
#2692 (comment).

Dott. Simone Pecora
Cell. 340 108 6698
Linkedin: Simone Pecora

thomaseichinger · 2015-09-29T20:55:35Z

@berbecche Please consider berbecche#1

OlegHahm · 2016-03-11T09:43:35Z

@thomaseichinger, would you be willing to adopt this apparently abandoned PR?

berbecche · 2016-03-11T09:45:54Z

I'm so sorry about it, but I'm too busy this period.

2016-03-11 10:43 GMT+01:00 Oleg Hahm [email protected]:

@thomaseichinger https://github.com/thomaseichinger, would you be
willing to adopt this apparently abandoned PR?

—
Reply to this email directly or view it on GitHub
#2692 (comment).

Dott. Simone Pecora
Cell. 340 108 6698
Linkedin: Simone Pecora

thomaseichinger · 2016-03-18T12:09:21Z

@OlegHahm I can, I actually have a branch with some fixes already laying around. Will pick it up as I find time.

OlegHahm · 2016-03-28T10:40:00Z

Thanks, @thomaseichinger. Won't make it for the release though.

kYc0o · 2016-07-25T14:53:07Z

Feature freeze -> postponed.

PeterKietzmann · 2016-09-27T20:51:29Z

#5573 and #2692 implement a driver for the same device. One is based on SPI, the other on I2C. Who is willing to merge both into one implementation :-)?

OlegHahm · 2016-10-12T17:50:10Z

@thomaseichinger, could you bring your fixes upstream please?

@lebrush, would you be willing to see if you can merge the SPI support into your PR?

lebrush · 2016-10-14T09:04:10Z

@OlegHahm i'll try to find some time to work on SPI for #5573. Works start to pile and I can't give a concrete date.

miri64 · 2016-10-31T18:01:15Z

Postponed due to feature freeze

PeterKietzmann · 2017-01-10T08:33:26Z

Closing this one in favour of #5573

berbecche added 4 commits March 23, 2015 11:59

Create Makefile

4824181

drivers: Added support for pn532 chip

73af490

drivers/pn532: modified libraries include

8ca11e1

drivers/pn532: modified some library directory path

3eb84fb

miri64 assigned haukepetersen Mar 24, 2015

miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Mar 24, 2015

berbecche added 3 commits March 27, 2015 16:31

Modified header directory position

d9b82cf

Added endif

987f6e5

Added cplusplus header

0978680

OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01

Fixed some bugs

e0efcd5

thomaseichinger added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 24, 2015

thomaseichinger assigned thomaseichinger and unassigned haukepetersen Aug 24, 2015

OlegHahm modified the milestone: Release NEXT MAJOR Sep 2, 2015

OlegHahm modified the milestone: Release 2015.12 Nov 28, 2015

OlegHahm modified the milestone: Release 2016.03 Dec 8, 2015

miri64 added the Area: drivers Area: Device drivers label Mar 18, 2016

OlegHahm modified the milestones: Release 2016.07, Release 2016.04 Mar 28, 2016

lebrush mentioned this pull request Jun 27, 2016

Implementation of PN532 NFC reader #5573

Merged

kYc0o modified the milestones: Release 2016.10, Release 2016.07 Jul 25, 2016

miri64 modified the milestones: Release 2017.01, Release 2016.10 Oct 31, 2016

PeterKietzmann closed this Jan 10, 2017

Conversation

berbecche commented Mar 23, 2015

Uh oh!

OlegHahm commented Aug 22, 2015

Uh oh!

thomaseichinger commented Aug 23, 2015

Uh oh!

thomaseichinger commented Aug 24, 2015

Uh oh!

berbecche commented Aug 24, 2015

Uh oh!

thomaseichinger commented Aug 24, 2015

Uh oh!

thomaseichinger commented Sep 1, 2015

Uh oh!

berbecche commented Sep 1, 2015

Uh oh!

thomaseichinger commented Sep 29, 2015

Uh oh!

OlegHahm commented Mar 11, 2016

Uh oh!

berbecche commented Mar 11, 2016

Uh oh!

thomaseichinger commented Mar 18, 2016

Uh oh!

OlegHahm commented Mar 28, 2016

Uh oh!

kYc0o commented Jul 25, 2016

Uh oh!

PeterKietzmann commented Sep 27, 2016

Uh oh!

OlegHahm commented Oct 12, 2016

Uh oh!

lebrush commented Oct 14, 2016

Uh oh!

miri64 commented Oct 31, 2016

Uh oh!

PeterKietzmann commented Jan 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants