make: made consistent use of spaces in Makefile.dep#2626
Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom Mar 18, 2015
Merged
make: made consistent use of spaces in Makefile.dep#2626haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Type: enhancement
Member
|
This is on purpose (at least for my part). Tabs and spaces are interpreted differently by |
Member
|
Never had the time to fix this for all lines though :-/ |
Contributor
Author
|
ok, then let me change the (all) tabs to spaces in this file... |
haukepetersen
force-pushed
the
fix_makedep_tabs
branch
2 times, most recently
from
95cbf67 to
8a8999f
Compare
haukepetersen
changed the title
haukepetersen
changed the title
haukepetersen
force-pushed
the
fix_makedep_tabs
branch
from
8a8999f to
ea8d752
Compare
Contributor
Author
|
now there is a consistent use of 2 space indention in |
Member
|
ACK when travis is happy. |
Member
|
The commit message is missing a letter. s/ake/make/ |
haukepetersen
force-pushed
the
fix_makedep_tabs
branch
from
ea8d752 to
daae886
Compare
Contributor
Author
|
ups, fixed it. |
Contributor
Author
|
and go. |
haukepetersen
added a commit
that referenced
this pull request
Mar 18, 2015
make: made consistent use of spaces in Makefile.dep
haukepetersen
added a commit
to haukepetersen/RIOT
that referenced
this pull request
Mar 25, 2015
Though technically it does not make a difference here, tabs have a different semantic meaning than spaces in Makefiles. To be consistent in RIOT we agreed to use two spaces for if conditions -> see RIOT-OS#2626.
muthmano-dev
pushed a commit
to muthmano-dev/RIOT
that referenced
this pull request
Mar 29, 2015
Though technically it does not make a difference here, tabs have a different semantic meaning than spaces in Makefiles. To be consistent in RIOT we agreed to use two spaces for if conditions -> see RIOT-OS#2626.
muthmano-dev
pushed a commit
to muthmano-dev/RIOT
that referenced
this pull request
Mar 30, 2015
Though technically it does not make a difference here, tabs have a different semantic meaning than spaces in Makefiles. To be consistent in RIOT we agreed to use two spaces for if conditions -> see RIOT-OS#2626.
haukepetersen
added a commit
that referenced
this pull request
Mar 31, 2015
Though technically it does not make a difference here, tabs have a different semantic meaning than spaces in Makefiles. To be consistent in RIOT we agreed to use two spaces for if conditions -> see #2626.
kushalsingh007
pushed a commit
to kushalsingh007/RIOT
that referenced
this pull request
Apr 12, 2015
Though technically it does not make a difference here, tabs have a different semantic meaning than spaces in Makefiles. To be consistent in RIOT we agreed to use two spaces for if conditions -> see RIOT-OS#2626.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems like some spaces slipped into the
Makefile.depwhich contains only tabs for indention otherwise...