Skip to content

net: initial import of an IPv6 neighbor cache#2461

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:ng_ipv6_nc/feat/initial
Mar 14, 2015
Merged

net: initial import of an IPv6 neighbor cache#2461
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:ng_ipv6_nc/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 16, 2015

Depends on #2433 merged
Depends on #2546 for debug output merged

@miri64 miri64 added NSTF State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet State: waiting for other PR State: The PR requires another PR to be merged first Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. labels Feb 16, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Feb 16, 2015
Lotterleben
Lotterleben reviewed Feb 17, 2015
View reviewed changes
sys/include/net/ng_ipv6.h Outdated
Copy link
Copy Markdown
Member

@Lotterleben Lotterleben Feb 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't this date & name deprecated? :)

Copy link
Copy Markdown
Member Author

@miri64 miri64 Feb 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It seems I have a broken template somewhere :D

Copy link
Copy Markdown
Member Author

@miri64 miri64 Feb 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This file is part of #2433 but thanks, never the less)

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 17, 2015
@miri64 miri64 mentioned this pull request Feb 19, 2015
Closed
36 tasks
@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from b051f47 to 1f5d857 Compare February 20, 2015 18:31
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 20, 2015

Rebased to current master

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 20, 2015
@miri64 miri64 mentioned this pull request Feb 20, 2015
Merged
OlegHahm
OlegHahm reviewed Feb 20, 2015
View reviewed changes
sys/include/net/ng_ipv6/nc.h Outdated
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Feb 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 8 big enough? I would definitely put an #ifndef... around this, so that the application designer - who might know more about expected node degree - can overwrite this.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Feb 20, 2015

I guess it's too earlier for a review, right?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 20, 2015

I think so too ;-)

@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from 9f5a25a to aafaf38 Compare February 24, 2015 06:38
@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch 2 times, most recently from cdf108b to f10d6ea Compare March 3, 2015 20:55
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 3, 2015

No longer WIP (except for tests)

@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from f10d6ea to d097c22 Compare March 3, 2015 21:06
@OlegHahm OlegHahm added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Mar 3, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 4, 2015

No longer WIP

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 6, 2015

Depends on #2546 for debug output

@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 6, 2015
@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from 9186e0c to 94f12c0 Compare March 11, 2015 23:42
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 11, 2015

Rebased to current #2546.

@miri64 miri64 mentioned this pull request Mar 12, 2015
Merged
OlegHahm
OlegHahm reviewed Mar 12, 2015
View reviewed changes
tests/unittests/tests-ipv6_nc/tests-ipv6_nc.c Outdated
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why + 1?

Copy link
Copy Markdown
Member Author

@miri64 miri64 Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have another interface than the already registered one

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 12, 2015

Addressed comments.

@OlegHahm OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 13, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 13, 2015

rebase is required.

OlegHahm
OlegHahm reviewed Mar 13, 2015
View reviewed changes
tests/unittests/tests-ipv6_nc/tests-ipv6_nc.c
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Mar 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this the only additional test, why do we need a separate function?

Copy link
Copy Markdown
Member Author

@miri64 miri64 Mar 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is an interface global search (see https://github.com/RIOT-OS/RIOT/pull/2461/files#diff-bfdde70ccc3110439add7db00ff1edd6R200). But yes, this test is missing in test_ipv6_nc_get__success1();

@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from 7162e66 to 1b35c99 Compare March 13, 2015 13:16
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 13, 2015

Rebased

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 13, 2015

Addressed comments

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 13, 2015

ACK, please squash.

@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from 78508d2 to 1d25aff Compare March 13, 2015 13:35
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 13, 2015

Rebased

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 13, 2015
@miri64 miri64 force-pushed the ng_ipv6_nc/feat/initial branch from 1d25aff to e740c6f Compare March 13, 2015 19:42
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 13, 2015

Sigh, after 6 h of idling Travis realized there was some missing documentation. So here we go again -.-

miri64 added a commit that referenced this pull request Mar 14, 2015
@miri64
Merge pull request #2461 from authmillenon/ng_ipv6_nc/feat/initial
99e810e 
net: initial import of an IPv6 neighbor cache
@miri64 miri64 merged commit 99e810e into RIOT-OS:master Mar 14, 2015
@miri64 miri64 deleted the ng_ipv6_nc/feat/initial branch March 14, 2015 01:26
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 14, 2015

Finally :D

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 16, 2015

Woohoo!

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 17, 2015

(now onwards to #2437?)

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 17, 2015

That's not my assignment. 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Milestone

Network Stack Task Force

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @OlegHahm @Lotterleben