Skip to content

ng_ipv6: provide support for ng_netif#2437

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:ng_ipv6_if/feat/initial
Mar 19, 2015
Merged

ng_ipv6: provide support for ng_netif#2437
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:ng_ipv6_if/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 11, 2015

Depends on #2433. (merged)

Depends on #2546 for debug output (merged)

@miri64 miri64 added this to the Network Stack Task Force milestone Feb 11, 2015
@miri64 miri64 added NSTF State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: network Area: Networking labels Feb 11, 2015
This was referenced Feb 11, 2015
Closed
Merged
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 6feca6f to 307dabf Compare February 16, 2015 21:03
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 16, 2015

Rebased to current #2433

@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 307dabf to 432b820 Compare February 20, 2015 13:50
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 20, 2015

Rebased to current master and merged in #2433

@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 302a683 to 25ff74a Compare February 20, 2015 18:29
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 20, 2015

Rebased to current master

@miri64 miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 20, 2015
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 25ff74a to d44244a Compare February 24, 2015 06:42
@miri64 miri64 mentioned this pull request Mar 2, 2015
Closed
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 0cb635a to 151aae8 Compare March 3, 2015 15:10
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 3, 2015

No longer WIP. Rebased to current master and squashed for review.

@miri64 miri64 removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Mar 3, 2015
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 151aae8 to 88eea3c Compare March 3, 2015 15:11
@miri64 miri64 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Mar 3, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 6, 2015

Depends on #2546 for debug output

@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 6, 2015
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 3940d05 to c650463 Compare March 7, 2015 19:00
This was referenced Mar 8, 2015
Closed
Merged
Merged
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from c650463 to 3b747f4 Compare March 11, 2015 23:40
OlegHahm
OlegHahm reviewed Mar 18, 2015
View reviewed changes
sys/include/net/ng_ipv6/netif.h
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Mar 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it might be obvious, I think the documentation should state that NULL will be returned if dest is not a unicast address. brain fart

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 18, 2015

Apart from the comments: ACK.

@OlegHahm OlegHahm assigned haukepetersen and unassigned OlegHahm Mar 18, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 18, 2015

Ok, apart from the function naming issues, everything's addressed from my point.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 18, 2015

And here we go with the function naming ;-)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 18, 2015

I'd like to make the unittests a little bit more readable however.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 18, 2015

I'd like to make the unittests a little bit more readable however.

I won't object this, but could you do so the next time, before I review it? 😛

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 18, 2015

And here we go with the function naming ;-)

👍

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 18, 2015

I won't object this, but could you do so the next time, before I review it? 😛

But your review gave me the idea :P

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 18, 2015

@OlegHahm done adapting ;-)

OlegHahm
OlegHahm reviewed Mar 18, 2015
View reviewed changes
tests/unittests/tests-ipv6_netif/tests-ipv6_netif.c Outdated
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Mar 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would this move up to l33.

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 18, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Mar 18, 2015

ACK, squash please!

@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from ac6bd68 to 4afd0c9 Compare March 18, 2015 15:49
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 18, 2015

Done

@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 18, 2015
@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from 4afd0c9 to c41b573 Compare March 18, 2015 16:05
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 18, 2015

(Adapted for changes in #2626)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 19, 2015

😭 There are still problems left.

@miri64 miri64 force-pushed the ng_ipv6_if/feat/initial branch from b786b72 to 09867e3 Compare March 19, 2015 14:13
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Mar 19, 2015

Libfixmath builds are failing so often that I had to rebase… I'm fed up and merge now -.-

miri64 added a commit that referenced this pull request Mar 19, 2015
@miri64
Merge pull request #2437 from authmillenon/ng_ipv6_if/feat/initial
3bb2b5f 
ng_ipv6: provide support for ng_netif
@miri64 miri64 merged commit 3bb2b5f into RIOT-OS:master Mar 19, 2015
@miri64 miri64 deleted the ng_ipv6_if/feat/initial branch March 19, 2015 14:14
@OlegHahm OlegHahm assigned OlegHahm and unassigned haukepetersen Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Milestone

Network Stack Task Force

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @OlegHahm @jnohlgard @haukepetersen