ng_ipv6_addr: initial import by miri64 · Pull Request #2433 · RIOT-OS/RIOT

miri64 · 2015-02-11T10:52:08Z

The motivation behind this module is to allow for address handling functions where they, but not the full IPv6 functionality might be needed. This new version of the IPv6 address data type utilizes the byteorder.h header to enforce network byte-order on its members.

miri64 · 2015-02-16T21:00:45Z

Rebased

OlegHahm · 2015-02-17T16:48:22Z

sys/include/net/ng_ipv6/addr.h

OlegHahm · 2015-02-17T18:53:37Z

I see your sneaky plan to make me spend more beer for overlooking a PR that needs squashing. ;)

miri64 · 2015-02-17T19:22:39Z

True! It absolutely has nothing to do with me not feeling responsible to set this Label ;P

miri64 · 2015-02-19T16:16:12Z

Reviewers, ping?

OlegHahm · 2015-02-19T16:24:01Z

As usual: I have to motivate myself to look at the unit tests again. ;)

LudwigKnuepfer · 2015-02-19T16:39:51Z

On the samr21-xpro:

$ make clean tests-ipv6_addr flash
...
$ make term
...
2015-02-19 17:38:33,325 - INFO # kernel_init(): This is RIOT! (Version: 2014.12-451-gd6680-ng_ipv6_addr/feat/initial)
2015-02-19 17:38:33,330 - INFO # kernel_init(): jumping into first task...
2015-02-19 17:38:33,345 - INFO # ..............................................
2015-02-19 17:38:33,346 - INFO # OK (46 tests)

OlegHahm · 2015-02-19T17:07:00Z

I'm not talking about running the tests btw ;)

LudwigKnuepfer · 2015-02-19T17:14:06Z

I understood that, just wanted to report this.

OlegHahm · 2015-02-20T08:52:55Z

sys/include/net/ng_ipv6/addr.h

__attribute__((packed))?

OlegHahm · 2015-02-20T15:15:34Z

tests/unittests/tests-ipv6_addr/tests-ipv6_addr.c

I don't get this test. Wouldn't it make more sense if a and b would be initially different?

They are, or more correct: a's value is unknown, since it is not initialized.

Aaah / read , for a =.

This is C, not Python 😀 (or is this possible oO?)

OlegHahm · 2015-02-20T15:46:15Z

ACK apart from #2433 (comment)

OlegHahm · 2015-02-20T16:33:02Z

Squash and go then (if Travis is happy).

The motivation behind this module is to allow for address handling functions where they, but not the full IPv6 functionality might be needed. This new version of the IPv6 address data type utilizes the byteorder.h header to enforce network byte-order on its members.

miri64 · 2015-02-20T16:41:12Z

Squashed; waiting for travis

ng_ipv6_addr: initial import

miri64 assigned OlegHahm Feb 11, 2015

miri64 added this to the Network Stack Task Force milestone Feb 11, 2015

miri64 added NSTF Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: network Area: Networking labels Feb 11, 2015

This was referenced Feb 11, 2015

Network stack refactoring: TODO list #2278

Closed

ng_ipv6: provide support for ng_netif #2437

Merged

ng_ipv6: initial import #2454

Merged

miri64 force-pushed the ng_ipv6_addr/feat/initial branch from ed40dc5 to a2ae2c5 Compare February 16, 2015 21:00

miri64 mentioned this pull request Feb 16, 2015

net: initial import of an IPv6 neighbor cache #2461

Merged

OlegHahm reviewed Feb 17, 2015
View reviewed changes

sys/include/net/ng_ipv6/addr.h Outdated

Copy link
Copy Markdown

Member

OlegHahm Feb 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parens

OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 17, 2015

OlegHahm reviewed Feb 20, 2015
View reviewed changes

sys/include/net/ng_ipv6/addr.h

Copy link
Copy Markdown

Member

OlegHahm Feb 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__((packed))?

miri64 added a commit to miri64/RIOT that referenced this pull request Feb 20, 2015

[SQUASH ME] move to same naming scheme as in RIOT-OS#2433

b387b42

OlegHahm reviewed Feb 20, 2015
View reviewed changes

miri64 force-pushed the ng_ipv6_addr/feat/initial branch from cbd34c1 to ff36abb Compare February 20, 2015 16:40

miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 20, 2015

miri64 added a commit that referenced this pull request Feb 20, 2015

Merge pull request #2433 from authmillenon/ng_ipv6_addr/feat/initial

dad4e8d

ng_ipv6_addr: initial import

miri64 merged commit dad4e8d into RIOT-OS:master Feb 20, 2015

miri64 deleted the ng_ipv6_addr/feat/initial branch February 20, 2015 18:27

miri64 added a commit to miri64/RIOT that referenced this pull request Feb 20, 2015

[SQUASH ME] move to same naming scheme as in RIOT-OS#2433

4bbf409

miri64 added a commit to miri64/RIOT that referenced this pull request Feb 24, 2015

[SQUASH ME] move to same naming scheme as in RIOT-OS#2433

d348a9d

miri64 mentioned this pull request Apr 16, 2015

ng_sixlowpan: initial import #2614

Merged

Conversation

miri64 commented Feb 11, 2015

Uh oh!

miri64 commented Feb 16, 2015

Uh oh!

OlegHahm Feb 17, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Feb 17, 2015

Uh oh!

miri64 commented Feb 17, 2015

Uh oh!

miri64 commented Feb 19, 2015

Uh oh!

OlegHahm commented Feb 19, 2015

Uh oh!

LudwigKnuepfer commented Feb 19, 2015

Uh oh!

OlegHahm commented Feb 19, 2015

Uh oh!

LudwigKnuepfer commented Feb 19, 2015

Uh oh!

OlegHahm Feb 20, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm Feb 20, 2015

Choose a reason for hiding this comment

Uh oh!

miri64 Feb 20, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm Feb 20, 2015

Choose a reason for hiding this comment

Uh oh!

miri64 Feb 20, 2015

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Feb 20, 2015

Uh oh!

OlegHahm commented Feb 20, 2015

Uh oh!

miri64 commented Feb 20, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants