net: added ng_nomac MAC implementation by haukepetersen · Pull Request #2426 · RIOT-OS/RIOT

haukepetersen · 2015-02-10T16:28:11Z

I re-implemented the nomac module using the current network stack APIs and paradigms.

Depends on

miri64 · 2015-02-10T16:43:55Z

sys/include/net/ng_nomac.h

s/nomac/ng_nomac

haukepetersen · 2015-02-10T16:49:12Z

rebased

miri64 · 2015-02-10T16:52:14Z

Hint: don't rebase all the stuff on top of each other. Choose one branch as your starting point and merge the others in one at a time. This way you don't create new commits that will never appear in master creating merge conflicts that will hurt you as soon as the original ones get merged ;-)

miri64 · 2015-02-10T16:54:07Z

e.g

$ git rebase -i netreg/feat/initial
# the vim view of rebase interactive-mode:
x git merge pktbuf/api/use-pkt_t
pick … your commits

miri64 · 2015-02-10T16:56:46Z

sys/net/link_layer/ng_nomac/ng_nomac.c

Are they called that way in netapi now? if yes, they slipped past my review. For consistency with the other setter/getters of netdev and the wrappers of netapi it self those should be called NG_NETAPI_MSG_TYPE_SET and NG_NETAPI_MSG_TYPE_GET

yes, this is what they are named. But I agree that they should be changed, will do.

haukepetersen · 2015-02-10T16:57:25Z

hm, someday I will learn this :-)

Anyway, put in the registering to netif and fixed the function naming issue.

haukepetersen · 2015-02-10T17:05:51Z

adapted NETAPI msg type names...

miri64 · 2015-02-11T20:48:04Z

Need's rebase + I predict, that you need to port netdev_dummy before the Travis will be happy ;-)

haukepetersen · 2015-02-12T12:12:05Z

I wait with the rebase until the dependencies are merged...

miri64 · 2015-02-12T14:26:16Z

sys/net/link_layer/ng_nomac/ng_nomac.c

missing \n

haukepetersen · 2015-02-12T14:33:41Z

added missing newlines...

haukepetersen · 2015-02-12T14:36:47Z

rephrased some documentation

miri64 · 2015-02-12T14:43:33Z

Just one question: what do you need ng_pktbuf for in this module?

haukepetersen · 2015-02-12T14:44:27Z

very good question, I guess I don't.

miri64 · 2015-03-09T12:30:28Z

sys/net/link_layer/ng_nomac/ng_nomac.c

here to s/next->//

also you have to release the packet here.

miri64 · 2015-03-09T12:32:58Z

Apart from my comments this looks okay. ACK when applied.

miri64 · 2015-03-09T13:58:06Z

sys/include/net/ng_nomac.h

indentation.

haukepetersen · 2015-03-10T12:42:37Z

rebased and addressed comments. @authmillenon, do you re-ack?

miri64 · 2015-03-10T13:01:09Z

sys/net/link_layer/ng_nomac/ng_nomac.c

Why only in debug context? Also: return is missing.

miri64 · 2015-03-10T13:02:40Z

Had still some minor complaints ;-)

haukepetersen · 2015-03-10T16:56:12Z

removed the ENABLE_DEBUG guards in case no once wants to get the data.

miri64 · 2015-03-10T18:54:06Z

I gave the NULL pointer controversy some thought: IF it might come to it, it's relatively easy to patch in afterwards. So ACK, please squash

miri64 · 2015-03-12T12:05:51Z

@haukepetersen please squash

haukepetersen · 2015-03-12T12:54:48Z

did. Let's wait for Travis...

haukepetersen · 2015-03-12T15:33:29Z

seems like Travis is a little lazy today...

haukepetersen · 2015-03-12T16:13:23Z

added one missing include, maybe this gets Travis going...

miri64 · 2015-03-12T19:36:41Z

Aaalmost done :D

miri64 · 2015-03-12T20:09:46Z

\o/

net: added ng_nomac MAC implementation

haukepetersen added NSTF Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: network Area: Networking labels Feb 10, 2015

haukepetersen added this to the Network Stack Task Force milestone Feb 10, 2015

haukepetersen assigned miri64 Feb 10, 2015

miri64 reviewed Feb 10, 2015
View reviewed changes

sys/include/net/ng_nomac.h Outdated

Copy link
Copy Markdown

Member

miri64 Feb 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nomac/ng_nomac

haukepetersen force-pushed the ng_nomac branch from 739d505 to cb1f5ca Compare February 10, 2015 16:48

haukepetersen added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 10, 2015

miri64 reviewed Feb 10, 2015
View reviewed changes

haukepetersen mentioned this pull request Feb 10, 2015

netdev: unify msg type macro with msg type macros in netapi #2427

Merged

miri64 mentioned this pull request Feb 10, 2015

Network stack refactoring: TODO list #2278

Closed

36 tasks

miri64 reviewed Feb 12, 2015
View reviewed changes

sys/net/link_layer/ng_nomac/ng_nomac.c Outdated

Copy link
Copy Markdown

Member

miri64 Feb 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing \n

miri64 reviewed Mar 9, 2015
View reviewed changes

sys/include/net/ng_nomac.h Outdated

Copy link
Copy Markdown

Member

miri64 Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.

haukepetersen force-pushed the ng_nomac branch from 71407ba to 84360d4 Compare March 10, 2015 12:41

miri64 reviewed Mar 10, 2015
View reviewed changes

sys/net/link_layer/ng_nomac/ng_nomac.c Outdated

Copy link
Copy Markdown

Member

miri64 Mar 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only in debug context? Also: return is missing.

miri64 mentioned this pull request Mar 11, 2015

Unittests sometimes hang at test_nomac_event_value #2577

Closed

haukepetersen force-pushed the ng_nomac branch from 25de728 to 2c5fb3d Compare March 12, 2015 12:54

net/nomac: removed legacy implementation

4bebf3b

miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 12, 2015

haukepetersen force-pushed the ng_nomac branch from 2c5fb3d to 549867b Compare March 12, 2015 16:12

net: added ng_nomac module

549867b

miri64 added a commit that referenced this pull request Mar 12, 2015

Merge pull request #2426 from haukepetersen/ng_nomac

ba14149

net: added ng_nomac MAC implementation

miri64 merged commit ba14149 into RIOT-OS:master Mar 12, 2015

haukepetersen deleted the ng_nomac branch March 13, 2015 08:52

jonas-rem mentioned this pull request May 20, 2015

802.15.4(e) MAC-Layer Task Force #3039

Closed

3 tasks

Conversation

haukepetersen commented Feb 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Feb 10, 2015

Uh oh!

miri64 commented Feb 10, 2015

Uh oh!

miri64 commented Feb 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Feb 10, 2015

Uh oh!

haukepetersen commented Feb 10, 2015

Uh oh!

miri64 commented Feb 11, 2015

Uh oh!

haukepetersen commented Feb 12, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Feb 12, 2015

Uh oh!

haukepetersen commented Feb 12, 2015

Uh oh!

miri64 commented Feb 12, 2015

Uh oh!

haukepetersen commented Feb 12, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 commented Mar 9, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Mar 10, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 commented Mar 10, 2015

Uh oh!

haukepetersen commented Mar 10, 2015

Uh oh!

miri64 commented Mar 10, 2015

Uh oh!

miri64 commented Mar 12, 2015

Uh oh!

haukepetersen commented Mar 12, 2015

Uh oh!

haukepetersen commented Mar 12, 2015

Uh oh!

haukepetersen commented Mar 12, 2015

Uh oh!

miri64 commented Mar 12, 2015

Uh oh!

miri64 commented Mar 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants