Skip to content

netif: Initial import of ng_* version#2417

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:netif/feat/initial
Feb 11, 2015
Merged

netif: Initial import of ng_* version#2417
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:netif/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 9, 2015

Depends on #2397 It does not

@miri64 miri64 added State: waiting for other PR State: The PR requires another PR to be merged first NSTF Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. and removed Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 9, 2015
@miri64 miri64 force-pushed the netif/feat/initial branch from dc4c88c to f70d0cc Compare February 9, 2015 18:45
@haukepetersen
Copy link
Copy Markdown
Contributor

I am not quite sure what the motivation behind this module (in the current form) is. Is this intended to act as central registry for network devices, as alternative to including the handling of these also into netreg?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

The motivation is to have a central registry of interfaces, that can be returned via the FIB. The reason I did not put it into netreg is two-fold:

  1. Nostalgia: this module is pretty much the ng version of net_if
  2. I don't see much connection in the functionality, other than registering PIDs somewhere. netreg is more a "I'm interested in packets of a certain type", netif is more "I want to be an endpoint for routing. Network layer what do you need of me." (Last sentence reflects the add/remove callbacks).

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

See it this way: you can leave netif out if you don't want routing in theory, but you can not leave out netreg, since it is integral to the inter-layer communication.

@cgundogan cgundogan added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 10, 2015
@cgundogan
Copy link
Copy Markdown
Member

ERROR: The following new files generate doxygen warnings: sys/include/net/ng_netif.h

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

Fixed

@miri64 miri64 mentioned this pull request Feb 10, 2015
36 tasks
@miri64 miri64 added this to the Network Stack Task Force milestone Feb 10, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor

I think I understand. So this module would also be used when I want to get a list of network devices for implementing shell commands, right?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

Yes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is unrelated, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe negative return value for consistency?

@haukepetersen
Copy link
Copy Markdown
Contributor

just this one thing about the return value and the ng_netreg/Makefile that has nothing to do with this PR... I will ack once this is fixed.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

Addressed comments

@haukepetersen
Copy link
Copy Markdown
Contributor

looks good to me -> ACK when squashed and Travis is happy.

@haukepetersen
Copy link
Copy Markdown
Contributor

kicked Travis

@miri64 miri64 force-pushed the netif/feat/initial branch from c883d9a to 894cd96 Compare February 11, 2015 09:53
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 11, 2015

Squashed

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 11, 2015
miri64 added a commit that referenced this pull request Feb 11, 2015
netif: Initial import of ng_* version
@miri64 miri64 merged commit b208371 into RIOT-OS:master Feb 11, 2015
@miri64 miri64 deleted the netif/feat/initial branch February 11, 2015 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants