Skip to content

microcoap: initial import#2383

Merged
Lotterleben merged 2 commits intoRIOT-OS:masterfrom
miri64:microcoap/feat/initial
Feb 11, 2015
Merged

microcoap: initial import#2383
Lotterleben merged 2 commits intoRIOT-OS:masterfrom
miri64:microcoap/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Feb 1, 2015

Adds microcoap as a package.

In contrast to libcoap this library only builds and parses CoAP packages and is totally independent of the way the packages are send. As far as I can gather, the feature set is not as complete as the one of libcoap.

Sadly there are no tests or solid documentation so I have to read a little code before I can include some tests. I tested if it compiles with

make USEPKG=microcoap -C examples/default/

@miri64 miri64 added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: pkg Area: External package ports labels Feb 1, 2015
@Lotterleben
Copy link
Copy Markdown
Member

Personally, I found the fact that utility functions like coap_dump() etc only exist if DEBUG is defined pretty annoying (makes a big mess with #ifdefs all over the place) and I'm guessing the fact that microcoap kind of has its own DEBUG may cause conflicts easily...

@Lotterleben
Copy link
Copy Markdown
Member

(I've started to slim down & port the microcoap example application here, in case that's relevant.)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 6, 2015

As already discussed during our meeting today: I'm on your side concerning the DEBUG-flag. Maybe a patch introducing RIOT's usual way would be more helpful. Simply to keep the flash size low, I would however prefer to keep them in #ifdef. Patches will follow.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 6, 2015

And 👍 for the example application

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 9, 2015

Merged @Lotterleben's proposal.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

@Lotterleben ACK?

@Lotterleben
Copy link
Copy Markdown
Member

@authmillenon Looks very good, I just want to double-check things really quick (finally figured out how marz works). Should be done in an hour.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

@Lotterleben Although closed, maybe you could write 4 sentences over at the marz PR to explain it's usage if you think could benefit anyone.

@Lotterleben
Copy link
Copy Markdown
Member

@LudwigOrtmann I've already opened a PR with some more documentation over at the marz repo and will explain its usage again in the README of the microcoap app, does that make sense? :)

@Lotterleben
Copy link
Copy Markdown
Member

Okay, seems to work fine when I test it with my example app, the Copper Plugin and marz. ACK :)

@Lotterleben Lotterleben added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 10, 2015
@miri64 miri64 force-pushed the microcoap/feat/initial branch from ad6223f to 3743798 Compare February 10, 2015 18:08
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 10, 2015

Squashed

@Lotterleben
Copy link
Copy Markdown
Member

Okay, will keep an eye on travis and merge as soon as I see green buttons :) Thanks again for making this pkg available!

@Lotterleben
Copy link
Copy Markdown
Member

Hmm, @authmillenon , why didn't you just squash my commit in with the rest? :)

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 11, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 11, 2015

Because I want to preserve authorship if someone adds to my PRs.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Feb 11, 2015

Kicked Travis.

Lotterleben added a commit that referenced this pull request Feb 11, 2015
@Lotterleben Lotterleben merged commit 6653e5b into RIOT-OS:master Feb 11, 2015
@miri64 miri64 deleted the microcoap/feat/initial branch February 11, 2015 11:41
@OlegHahm OlegHahm mentioned this pull request Mar 13, 2015
@OlegHahm OlegHahm modified the milestone: Release 2015.06 Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: pkg Area: External package ports Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants