periph/i2c: added means to make I2C thread-safe#2323
Merged
PeterKietzmann merged 4 commits intoRIOT-OS:masterfrom Jan 20, 2015
Merged
periph/i2c: added means to make I2C thread-safe#2323PeterKietzmann merged 4 commits intoRIOT-OS:masterfrom
PeterKietzmann merged 4 commits intoRIOT-OS:masterfrom
Conversation
thomaseichinger
added
Process: API change
44 tasks
Member
|
ACK |
Member
|
@thomaseichinger did you link this PR in issue #2314? If so, do you want to change all other i2c implementations in here? I could also adapt some, just want to avoid that our work collides |
As discussed in RIOT-OS#2289 this changes provide means to use the i2c interface safely within multible threads.
thomaseichinger
force-pushed
the
i2c_mutex
branch
from
98f3150 to
830b2b2
Compare
Member
Author
|
@PeterKietzmann I did, updated adopting all other existing i2c implementations. |
Member
|
Ah haven't seen this. Ok I'll go through the commits |
Member
Author
|
@PeterKietzmann As the proposed concept doesn't break the current usage of the interface I decided to adopt i2c's uses separately. Would you mind taking over this task? |
Member
|
@thomaseichinger. ACK for this PR. I could adapt the uses. Thanks for the list in #2314. I'll register my name to some , just to avoid collisions if someone else hops in. If not, i'll adapt all within the next days |
Member
|
Everything is fine. ACK |
PeterKietzmann
added a commit
that referenced
this pull request
Jan 20, 2015
periph/i2c: added means to make I2C thread-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2289 this changes provide means to use the i2c interface safely within multiple threads. Missing implementations will be provided as the concept is accepted. Implementation is analog to #2290.