Conversation
sys/include/pkt.h
Outdated
|
I like the idea of the pkt type. I would actually strongly opt for removing the (redundant) hlist data-structue and also remove the hlist from the functions naming -> keep it as simple as possible! |
|
But headers are no packets. As someone not familiar with this I would be very confused if I see packets get stuffed into packets. Furthermore, the semantics become very different in the packet buffer (only Think of the |
|
TL;DR while removing |
|
Afterthought: You commented on the wrong PR. Please discuss introduction of |
d6608d5 to
216d580
Compare
|
Rebased to make changes apparent here, too. ;-) |
|
I thought about this a bit more: I would actually vote for renaming the thing completely to something like Anyway, as I see it the buffer can be used for more than just packet/header buffering, why not use it also to store addresses or whatever? Regarding the API: I don't think we need a dedicated API for headers, by just working on a generic data structure we simplify/shorten code with the same results - in the end it's not the genuine user that is working inside the network stack - but people who know at least to some extend what they are doing... |
|
oh, just noticed: this comment should have probably been posted for #2158, sorry |
|
@authmillenon please rebase |
216d580 to
f59f9ee
Compare
|
Rebased to #2285 and added it as dependency in description + ported |
74d8012 to
6af9538
Compare
|
Closed in favor for #2400 |
Simplifies netapi quiet a bit.
Depends on
#2158(merged). There is also a small dependency on#1968(merged) or vice-versa, but I'll just will fix the PR that get's merged later ;-)Depends on #2285