Add support for Kinetis K60 CPUs and Eistec Mulle IoT board by jnohlgard · Pull Request #2282 · RIOT-OS/RIOT

jnohlgard · 2015-01-12T13:50:34Z

This PR adds support for the Freescale Kinetis K60 CPUs and basic functionality of the Eistec Mulle IoT board.

~~This requires the kinetis_common framework in #2265~~ - merged

~~Depends on: #2605, #2321~~ - temporarily disabled functionality depending on these until they are merged

Tested on the following Freescale Kinetis K60 CPUs:

MK60DN512VLL10

The port should with a high probability also support the following variations of the above CPUs (untested):

MK60DN256VLL10

And possibly also (with some minor changes to ldscripts):

MK60DX256VLL10
MK60DX512VLL10
MK60DN512VLQ10
MK60DN256VLQ10
MK60DX256VLQ10
MK60DN512VMC10
MK60DN256VMC10
MK60DX256VMC10
MK60DN512VMD10
MK60DX256VMD10
MK60DN256VMD10

Currently not working on the following CPUs (Missing PIT channel chaining necessary for kinetis_common/periph/timer implementation):

MK60DN256ZVLL10
MK60DN512ZVLL10
MK60DX256ZVLL10
MK60DX512ZVLL10
MK60DN512ZVLQ10
MK60DN256ZVLQ10
MK60DX256ZVLQ10
MK60DN512ZVMC10
MK60DN256ZVMC10
MK60DX256ZVMC10
MK60DN512ZVMD10
MK60DX256ZVMD10
MK60DN256ZVMD10

OlegHahm · 2015-01-12T15:08:02Z

Oh wow! Great! ☀️

jnohlgard · 2015-01-13T08:28:44Z

@jfischer-phytec-iot I assigned you, I figured we can review each others' Kinetis code. (I am already assigned to #2265 )

thomaseichinger · 2015-02-05T09:23:58Z

As #2265 got merged, is this PR ready for review?

jnohlgard · 2015-02-05T09:33:57Z

It needs some more work still. I will ping back when it is ready, do you have time to do the review, @thomaseichinger ?
I get the feeling that @jfischer-phytec-iot is busy working on preparing the Phywave KWxx platforms.

thomaseichinger · 2015-02-05T09:39:46Z

I can do eyes only review for sure, regarding testing functionality I will have to let to you from a lack of hardware.

jfischer-no · 2015-02-05T09:57:03Z

I will unfortunately have no time before Saturday . The Embedded World is soon 😅
But in between I will look at a few lines..

jnohlgard · 2015-02-07T15:28:02Z

Updated code, ready for review, though waiting for #2393 in order to get the kinetis_common linker script included by the K60 linker scripts

thomaseichinger · 2015-02-17T11:08:24Z

boards/mulle/Makefile.include

If the Mulle board has a FTDI chip this will be /dev/tty.usbserial*.

Thank you for your help with OSX specifics.

jnohlgard · 2015-03-23T04:39:25Z

Rebased and addressed all static-tests fails, except for the NEEDS SQUASHING part.

LudwigKnuepfer · 2015-03-23T17:52:24Z

I would suggest to match the CMSIS Peripheral Access Layer for MK60DZ10 string and possibly also the version, because the license header itself is too generic.

jnohlgard · 2015-03-23T20:21:18Z

@LudwigOrtmann I made a new attempt at a license pattern. This one is very specific and will only match the MK60DZ10 header.

LudwigKnuepfer · 2015-03-23T21:05:44Z

I approve =)

jfischer-no · 2015-03-24T14:49:32Z

@gebart Why you can not use MK60DZ10 with the MK60D10 header (possibly with adjustments) ?

jnohlgard · 2015-03-24T14:54:39Z

@jfischer-phytec-iot because Freescale switched a bunch of modules when they upgraded the silicon. (e.g. RNGA/RNGB, MCG acts differently, LLWU is different, PIT is missing the chaining functionality in 1.x etc. etc.)

It will be alot of pain for no gain other than getting rid of the extra license pattern, since we already have permission to use the header.

See http://cache.freescale.com/files/32bit/doc/app_note/AN4445.pdf

jfischer-no · 2015-03-24T15:01:27Z

@gebart 😟 ok, I have looked at it with vimdiff, terrible...

jnohlgard · 2015-03-28T06:36:30Z

Travis finally decided to come through after a week of trying to build this. Everything is green now except for the NEEDS SQUASHING part.

LudwigKnuepfer · 2015-03-28T07:00:24Z

I guess nobody has hardware to test this except you @gebart ?

LudwigKnuepfer · 2015-03-28T07:06:12Z

I guess the "Request for Comments" can be removed?

LudwigKnuepfer · 2015-03-28T07:06:38Z

Doxygen looks fine.

jnohlgard · 2015-03-28T07:12:03Z

@LudwigOrtmann yeah, I guess so.

Contact me (or [email protected]) if you are interested in these devices.

LudwigKnuepfer · 2015-03-28T07:12:43Z

Then please go ahead and squash (and remove the label).

Tested on the following Freescale Kinetis K60 CPUs: - MK60DN512VLL10 The port should with a high probability also support the following variations of the above CPUs (untested): - MK60DN256VLL10 And possibly also: - MK60DX256VLL10 - MK60DX512VLL10 - MK60DN512VLQ10 - MK60DN256VLQ10 - MK60DX256VLQ10 - MK60DN512VMC10 - MK60DN256VMC10 - MK60DX256VMC10 - MK60DN512VMD10 - MK60DX256VMD10 - MK60DN256VMD10 Currently not working on the following CPUs (Missing PIT channel chaining necessary for kinetis_common/periph/timer implementation): - MK60DN256ZVLL10 - MK60DN512ZVLL10 - MK60DX256ZVLL10 - MK60DX512ZVLL10 - MK60DN512ZVLQ10 - MK60DN256ZVLQ10 - MK60DX256ZVLQ10 - MK60DN512ZVMC10 - MK60DN256ZVMC10 - MK60DX256ZVMC10 - MK60DN512ZVMD10 - MK60DX256ZVMD10 - MK60DN256ZVMD10 Regarding header files from Freescale: dist/tools/licenses: Add Freescale CMSIS PAL license pattern Redistribution is OK according to: https://community.freescale.com/message/477976?et=watches.email.thread#477976 Archive copy in case the above link disappears: https://web.archive.org/web/20150328073057/https://community.freescale.com/message/477976?et=watches.email.thread Applies to: - MK60DZ10.h (K60 variant)

Initially supports only Mulles with serial number > 220 (due to missing MK60DN256ZVLL10 support in k60). See also: https://github.com/RIOT-OS/RIOT/wiki/Board%3A-Mulle Signed-off-by: Joakim Gebart <[email protected]>

jnohlgard · 2015-03-28T07:36:19Z

Rebased and squashed, waiting for Travis

LudwigKnuepfer · 2015-03-28T13:52:45Z

⏳

OlegHahm · 2015-04-09T22:21:17Z

All lights are green.

Add support for Kinetis K60 CPUs and Eistec Mulle IoT board

jnohlgard force-pushed the pr/k60-initial branch from 304422b to 6c4ee7d Compare January 12, 2015 14:41

jnohlgard mentioned this pull request Jan 12, 2015

cpu: RIOT port for Freescale Kinetis CPUs #2188

Closed

45 tasks

jnohlgard assigned jfischer-no Jan 13, 2015

jfischer-no mentioned this pull request Jan 15, 2015

Support for Freescale Kinetis MCUs, kinetis_common #2265

Merged

jnohlgard mentioned this pull request Feb 5, 2015

Building inside a Docker container #2391

Closed

jnohlgard removed the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 5, 2015

jnohlgard force-pushed the pr/k60-initial branch from 6c4ee7d to 9ee00f8 Compare February 5, 2015 09:40

jnohlgard force-pushed the pr/k60-initial branch from 27c1207 to 696fe19 Compare February 7, 2015 15:26

jnohlgard added the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 7, 2015

jnohlgard removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Feb 9, 2015

jnohlgard force-pushed the pr/k60-initial branch 2 times, most recently from 14a3263 to 00d3bd9 Compare February 9, 2015 20:02

jnohlgard removed the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 14, 2015

thomaseichinger reviewed Feb 17, 2015
View reviewed changes

jnohlgard removed the Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR label Mar 28, 2015

Joakim Gebart added 2 commits March 28, 2015 08:30

jnohlgard force-pushed the pr/k60-initial branch from 2dbb8ea to 4ae819c Compare March 28, 2015 07:32

jnohlgard removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 28, 2015

Lotterleben force-pushed the master branch from 1d9f189 to d4e068b Compare March 31, 2015 09:52

OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01

OlegHahm added a commit that referenced this pull request Apr 9, 2015

Merge pull request #2282 from gebart/pr/k60-initial

c1ecccf

Add support for Kinetis K60 CPUs and Eistec Mulle IoT board

OlegHahm merged commit c1ecccf into RIOT-OS:master Apr 9, 2015

OlegHahm modified the milestone: Release 2015.06 Apr 29, 2015

jnohlgard deleted the pr/k60-initial branch May 10, 2015 08:26

Conversation

jnohlgard commented Jan 12, 2015

Uh oh!

OlegHahm commented Jan 12, 2015

Uh oh!

jnohlgard commented Jan 13, 2015

Uh oh!

thomaseichinger commented Feb 5, 2015

Uh oh!

jnohlgard commented Feb 5, 2015

Uh oh!

thomaseichinger commented Feb 5, 2015

Uh oh!

jfischer-no commented Feb 5, 2015

Uh oh!

jnohlgard commented Feb 7, 2015

Uh oh!

thomaseichinger Feb 17, 2015

Choose a reason for hiding this comment

Uh oh!

jnohlgard Feb 17, 2015

Choose a reason for hiding this comment

Uh oh!

jnohlgard commented Mar 23, 2015

Uh oh!

LudwigKnuepfer commented Mar 23, 2015

Uh oh!

jnohlgard commented Mar 23, 2015

Uh oh!

LudwigKnuepfer commented Mar 23, 2015

Uh oh!

jfischer-no commented Mar 24, 2015

Uh oh!

jnohlgard commented Mar 24, 2015

Uh oh!

jfischer-no commented Mar 24, 2015

Uh oh!

jnohlgard commented Mar 28, 2015

Uh oh!

LudwigKnuepfer commented Mar 28, 2015

Uh oh!

LudwigKnuepfer commented Mar 28, 2015

Uh oh!

LudwigKnuepfer commented Mar 28, 2015

Uh oh!

jnohlgard commented Mar 28, 2015

Uh oh!

LudwigKnuepfer commented Mar 28, 2015

Uh oh!

jnohlgard commented Mar 28, 2015

Uh oh!

LudwigKnuepfer commented Mar 28, 2015

Uh oh!

OlegHahm commented Apr 9, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants