Murdock results

✔️ PASSED

5209c1b drivers/atwinc15x0: use strncpy in _atwinc15x0_sta_set_current_ssid

Artifacts

• Documentation preview

I wonder if this couldn't cause an additional problem if ARRAY_SIZE(ssid) is smaller than ARRAY_SIZE(atwinc15x0->ssid). Then we'd copy more bytes than we should.

Something like MIN(ARRAY_SIZE(ssid), ARRAY_SIZE(atwinc15x5->ssid))-1 would be possible
But I guess we just don't know the length of ssid at compile time?

From what I found the length for ssid is either M2M_MAX_SSID_LEN or WIFI_SSID_LEN_MAX + 1, which are both 33.

I'm trying to test the change with a feather-m0-wifi and a arduino-mkr1000 as well. For both boards iw <iface> scan command doesn't work, neither with this change nor in current master not in release 2023.10 🤔 I have no idea what I'm doing wrong. It just hangs after the scan and the list of APs is empty:

> iw 6 scan
 SSID                            | SEC             | RSSI  | CHANNEL
---------------------------------+-----------------+-------+--------