cpu/esp8266: fix the crashes on startup in vendor code#22010
Merged
gschorcht merged 1 commit intoRIOT-OS:masterfrom Jan 23, 2026
Merged
cpu/esp8266: fix the crashes on startup in vendor code#22010gschorcht merged 1 commit intoRIOT-OS:masterfrom
gschorcht merged 1 commit intoRIOT-OS:masterfrom
Conversation
RIOT uses an older version of the RTOS SDK, in which the `call_user_startup` function copied a fixed number of 3 segments from flash memory to RAM. This led to random crashes when there were only 2 segments to copy in flash memory. With this fix, the number of segments specified in the image header is now used.
85 tasks
maribu
approved these changes
Jan 23, 2026
Contributor
|
Thanks for fixing this one! |
Contributor
Author
Wait, now the example crashes when the |
Contributor
Author
Please forget it, I used a version of ESP8266-RTOS-SDK which I modified for the investigation of another problem with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes arbitrary crashes or hangs when starting ESP8266 boards.
RIOT uses an older version of the vendor code from the ESP8266-RTOS-SDK, in which the
call_user_startupfunction tried to copy a fixed number of 3 segments from flash memory to RAM. This led to arbitrary crashes or hangs during startup when there were only two segments in the flash memory that needed to be copied to RAM. With this fix, the number of segments specified in the image header is now used.Testing procedure
Compile and flash an ESP8266 board with command
Without the PR, the example should get stuck or crash at startup. With the PR, the example should work.
Issues/PRs references