Skip to content

dist/tools/esptools: remove non-existing 'esptool' tool target#21971

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
crasbe:pr/esptool_fix
Jan 4, 2026
Merged

dist/tools/esptools: remove non-existing 'esptool' tool target#21971
maribu merged 1 commit intoRIOT-OS:masterfrom
crasbe:pr/esptool_fix

Conversation

@crasbe
Copy link
Copy Markdown
Contributor

@crasbe crasbe commented Jan 4, 2026

Contribution description

Commit be9172f from PR #21522 errorneously introduced the esptool as an installation target, which does not exist.

This PR removes that regression.

Discovered by tomnatosoup in the Matrix chat.

Testing procedure

Run dist/tools/esptools/install.sh and observe that esptool is not displayed as an option anymore:

Before:

buechse@skyleaf:~/RIOTstuff/riot-vanillaice/RIOT$ dist/tools/esptools/install.sh
Usage: install.sh <tool>
       install.sh gdb <platform>
       install.sh qemu <platform>
<tool> = all | esptool | gdb | openocd | qemu |
         esp8266 | esp32 | esp32c3 | esp32c6 | esp32h2 | esp32s2 | esp32s3
<platform> = xtensa | riscv

After:

buechse@skyleaf:~/RIOTstuff/riot-vanillaice/RIOT$ dist/tools/esptools/install.sh
Usage: install.sh <tool>
       install.sh gdb <platform>
       install.sh qemu <platform>
<tool> = all | gdb | openocd | qemu |
         esp8266 | esp32 | esp32c3 | esp32c6 | esp32h2 | esp32s2 | esp32s3
<platform> = xtensa | riscv

Issues/PRs references

Introduced in #21522.

@crasbe crasbe requested a review from gschorcht January 4, 2026 12:22
@crasbe crasbe added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 4, 2026
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Jan 4, 2026
@riot-ci
Copy link
Copy Markdown

riot-ci commented Jan 4, 2026

Murdock results

✔️ PASSED

51854f4 dist/tools/esptools: remove 'esptool' tool target

Success Failures Total Runtime
1 0 1 01m:14s

Artifacts

@maribu maribu enabled auto-merge January 4, 2026 12:24
@maribu maribu added this pull request to the merge queue Jan 4, 2026
Merged via the queue into RIOT-OS:master with commit 48bb988 Jan 4, 2026
30 checks passed
@crasbe crasbe deleted the pr/esptool_fix branch January 4, 2026 12:58
@gschorcht gschorcht mentioned this pull request Jan 5, 2026
Merged
@leandrolanzieri leandrolanzieri added this to the Release 2026.01 milestone Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht

Assignees

No one assigned

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2026.01

Development

Successfully merging this pull request may close these issues.

4 participants

@crasbe @riot-ci @maribu @leandrolanzieri