sys/event: fix stack size requirement build system integration#21957
Merged
maribu merged 3 commits intoRIOT-OS:masterfrom Dec 16, 2025
Merged
Conversation
maribu
requested review from
MichelRottleuthner,
aabadie,
kaspar030 and
leandrolanzieri
as code owners
maribu
added
Type: bug
github-actions
bot
added
Area: tests
maribu
force-pushed
the
sys/event/thread-stack-size-build-system-integration-fix
branch
from
d49212d to
ddd9522
Compare
The stack requirements were applied to the wrong thread in case of a shared thread managing medium and lowest priority queues (in other words: when `event_thread_medium` is not used). This fixes the implementation and corrects the documentation to which thread handles which queues.
On native the stack size needs to be a bit larger than on MCUs to not run into a stack overflow.
maribu
force-pushed
the
sys/event/thread-stack-size-build-system-integration-fix
branch
from
ddd9522 to
adf423e
Compare
Member
Author
|
OK, all regressions should now also be fixed. I'll do another spin on real hardware to see if the fix still works as expected. |
Member
Author
|
Yep, the stack indeed now still is above the 512 B and at the 1024 B minimum set via |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
maribu
deleted the
sys/event/thread-stack-size-build-system-integration-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The stack requirements were applied to the wrong thread in case of a shared thread managing medium and lowest priority queues (in other words: when
event_thread_mediumis not used).This fixes the implementation and corrects the documentation to which thread handles which queues.
Testing procedure
Use a
event_thread, bump the requirements of the medium event queue, then runps. It will not show an increase inmasterof the single event thread, but will show now with this PR.Issues/PRs references
None