nanocoap: use default blocksize2 in coap_block2_init()#21952
Merged
benpicco merged 3 commits intoRIOT-OS:masterfrom Dec 11, 2025
Merged
nanocoap: use default blocksize2 in coap_block2_init()#21952benpicco merged 3 commits intoRIOT-OS:masterfrom
benpicco merged 3 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: network
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
coap_get_blockopt
branch
from
7f836be to
83275fd
Compare
Teufelchen1
reviewed
Dec 11, 2025
Teufelchen1
approved these changes
Dec 11, 2025
Contributor
Author
|
After thinking about it a bit more, |
Teufelchen1
approved these changes
Dec 11, 2025
benpicco
force-pushed
the
coap_get_blockopt
branch
from
5708457 to
93b7d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
coap_block2_init()defaulting to 0 when no block1 option was found just looks like a bug.But for the simple fix to work we have to prevent
coap_find_option()from settingszxto 0 when no block option was found. Settingblknumto 0 does make sense though and we can use it to simplifycoap_get_block()- 0 shifted by anything will always be 0, so no need for a special case.Testing procedure
Issues/PRs references
alternative to #21951