nanocoap: Default the blocksize2 to the configured value#21951
Closed
Teufelchen1 wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
nanocoap: Default the blocksize2 to the configured value#21951Teufelchen1 wants to merge 1 commit intoRIOT-OS:masterfrom
Teufelchen1 wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
|
Since you've merged #21952 I think we can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Hii 🐧
The CoAP Blocksize RFC7959 says:
RIOTs current behaviour is indeed to treat a missing Block2 option as
SZX == 0and consequently sends16 bytesof response.I think this "feels" like a bug. Why would I want only 16 bytes if I (as the request sender) didn't bother to restrict the block size? It is very likely that I can handle more than 16 byte responses. In addition, any resource that is bigger than 16 bytes will be truncated to 16 bytes.
We already have a configuration for our maximum blocksize, I propose to default to that.
Testing procedure
Issues/PRs references