.gitattributes: mark package-lock.json as binary#21945
Merged
AnnsAnns merged 1 commit intoRIOT-OS:masterfrom Dec 9, 2025
Merged
.gitattributes: mark package-lock.json as binary#21945AnnsAnns merged 1 commit intoRIOT-OS:masterfrom
AnnsAnns merged 1 commit intoRIOT-OS:masterfrom
Conversation
AnnsAnns
reviewed
Dec 9, 2025
| *.md conflict-marker-size=100 | ||
| *.txt conflict-marker-size=100 | ||
| *.svg binary | ||
| package-lock.json binary |
Member
There was a problem hiding this comment.
I read through a few sites and am still a bit unsure, does this even apply retroactively to a file already in the git history?
Member
Author
There was a problem hiding this comment.
From how I understand it, it should be treated as binary from the next time on, that it is being updated
AnnsAnns
added
CI: ready for build
AnnsAnns
approved these changes
Dec 9, 2025
Member
AnnsAnns
left a comment
AnnsAnns
left a comment
There was a problem hiding this comment.
Talked with maintainers, this should work locally, does not work for Github, which is arguably still an improvement. Ty.
crasbe
added
the
Type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Starlight uses Node.js and NPM (Node Package Manager) similar to Cargo in Rust it creates a package-lock.json, which is generated when updating versions of packages.
I think it is reasonable to treat this as binary similar to how we also treat Cargo.lock as binary.
EDIT: Blocks #21944