dist/tools/dlcache: make script more portable#21924
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Dec 2, 2025
Merged
Conversation
- do not use `bash` in shebang, e.g. containers may not ship bash - do not use `flock -w <timeout_secs> ...`, but `timeout <timeout_secs> flock ...` to be portable to even busybox's flock implementation - sha512sum is more common on Linux than shasum
maribu
force-pushed
the
dlcache/portable
branch
from
b54055d to
21824cc
Compare
crasbe
added
Type: enhancement
crasbe
reviewed
Dec 2, 2025
| rm "$lockfile" | ||
| } | ||
| else | ||
| SHA512="sha512sum" |
Contributor
There was a problem hiding this comment.
What's the reason for this change? shasum should be portable 🤔
Member
Author
There was a problem hiding this comment.
sha512sum --verison
sha512sum: unrecognized option: verison
BusyBox v1.37.0 (2025-08-05 16:40:33 UTC) multi-call binary.
Usage: sha512sum [-c[sw]] [FILE]...
Print or check SHA512 checksums
-c Check sums against list in FILEs
-s Don't output anything, status code shows success
-w Warn about improperly formatted checksum lines
/ # shasum --version
/bin/sh: shasum: not found
/ #
Contributor
There was a problem hiding this comment.
Huh, okay. Haven't tried Busybox.
crasbe
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
bashin shebang, e.g. containers may not ship bashflock -w <timeout_secs> ..., buttimeout <timeout_secs> flock ...to be portable to even busybox's flock implementationTesting procedure
dlcache should still work as before
Issues/PRs references
None