sys/usb/cdc_acm: don't generate flush event when disconnected#21914
Merged
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom Nov 25, 2025
Merged
sys/usb/cdc_acm: don't generate flush event when disconnected#21914Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: USB
crasbe
added
Type: enhancement
Teufelchen1
approved these changes
Nov 25, 2025
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
lgtm
Did not test it but low impact & easy to bisect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The event handler will check the connected state too, but when we are not connected we don't have to generate the event in the first place.
Testing procedure
Issues/PRs references
follow-up to #21890