Skip to content

pkg/mpaland-printf: Add missing wrapper for fputs [backport 2025.10]#21892

Merged
maribu merged 1 commit intoRIOT-OS:2025.10-branchfrom
maribu:backport/2025.10/pkg/mpaland-printf/wrap-fputs
Nov 18, 2025
Merged

pkg/mpaland-printf: Add missing wrapper for fputs [backport 2025.10]#21892
maribu merged 1 commit intoRIOT-OS:2025.10-branchfrom
maribu:backport/2025.10/pkg/mpaland-printf/wrap-fputs

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Nov 18, 2025

Backport of #21889

Contribution description

Another endpoint that was forgotten to overwrite. This fixes the output of the i2c_scan shell command that is e.g. included in the test app in tests/periph/i2c.

Testing procedure

In master

$ make BOARD=same54-xpro -C tests/periph/i2c flash term
make: Entering directory '/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c'
Building application "tests_i2c" for "same54-xpro" with CPU "samd5x".
   text	  data	   bss	   dec	   hex	filename
  24500	   172	  2844	 27516	  6b7c	/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c/bin/same54-xpro/tests_i2c.elf
[...]
> i2c_scan 0
2025-11-17 20:36:56,633 # i2c_scan 0
2025-11-17 20:36:56,636 # Scanning I2C device 0...
2025-11-17 20:36:56,642 # addr not ack'ed = "-", addr ack'ed = "X", addr reserved = "R", error = "E"
2025-11-17 20:36:56,645 #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2025-11-17 20:36:56,646 # 
2025-11-17 20:36:56,648 # 
2025-11-17 20:36:56,650 # 
2025-11-17 20:36:56,652 # 
2025-11-17 20:36:56,654 # 
2025-11-17 20:36:56,656 # 
2025-11-17 20:36:56,657 # 
2025-11-17 20:36:56,658 # 
> i2c_scan 0
2025-11-17 20:37:00,096 # 0x00 R R R R R R R R - - - - - - - -0x10 - - - - - - - - - - - - - - - -0x20 - - - - - - - - - - - - - - - -0x30 - - - - - - - - - - - - - - - -0x40 - - - - - - - - - - - - - - - -0x50 - - - - - - - - - - - - - - - -0x60 - - - - - - - - - - - - - - - -0x70 - - - - - - - - R R R R R R R Ri2c_scan 0
2025-11-17 20:37:00,098 # Scanning I2C device 0...
2025-11-17 20:37:00,104 # addr not ack'ed = "-", addr ack'ed = "X", addr reserved = "R", error = "E"
2025-11-17 20:37:00,107 #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2025-11-17 20:37:00,108 # 
2025-11-17 20:37:00,110 # 
2025-11-17 20:37:00,112 # 
2025-11-17 20:37:00,114 # 
2025-11-17 20:37:00,116 # 
2025-11-17 20:37:00,118 # 
2025-11-17 20:37:00,120 # 
2025-11-17 20:37:00,121 #

This PR

$ make BOARD=same54-xpro -C tests/periph/i2c flash term
make: Entering directory '/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c'
Building application "tests_i2c" for "same54-xpro" with CPU "samd5x".
[...]
   text	  data	   bss	   dec	   hex	filename
  24132	   172	  2844	 27148	  6a0c	/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c/bin/same54-xpro/tests_i2c.elf
[...]
> i2c_scan 0
2025-11-17 20:35:12,668 # i2c_scan 0
2025-11-17 20:35:12,670 # Scanning I2C device 0...
2025-11-17 20:35:12,677 # addr not ack'ed = "-", addr ack'ed = "X", addr reserved = "R", error = "E"
2025-11-17 20:35:12,680 #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2025-11-17 20:35:12,684 # 0x00 R R R R R R R R - - - - - - - -
2025-11-17 20:35:12,689 # 0x10 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,694 # 0x20 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,698 # 0x30 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,703 # 0x40 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,708 # 0x50 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,713 # 0x60 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,717 # 0x70 - - - - - - - - R R R R R R R R

Issues/PRs references

None

@maribu
pkg/mpaland-printf: Add missing wrapper for fputs
8fbe6fc 
Another endpoint that was forgotten to overwrite. This fixes the
output of the `i2c_scan` shell command that is e.g. included in the
test app in `tests/periph/i2c`.

(cherry picked from commit b67daab)
@maribu maribu added Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 18, 2025
@maribu maribu requested a review from benpicco November 18, 2025 05:04
@maribu maribu mentioned this pull request Nov 18, 2025
Merged
@maribu maribu enabled auto-merge November 18, 2025 05:04
@riot-ci
Copy link
Copy Markdown

riot-ci commented Nov 18, 2025

Murdock results

✔️ PASSED

8fbe6fc pkg/mpaland-printf: Add missing wrapper for fputs

Success Failures Total Runtime
10561 0 10561 12m:53s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 18, 2025
Merged via the queue into RIOT-OS:2025.10-branch with commit 0637f72 Nov 18, 2025
30 checks passed
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mguetschow mguetschow mguetschow approved these changes

@benpicco benpicco Awaiting requested review from benpicco

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2025.10

Development

Successfully merging this pull request may close these issues.

4 participants

@maribu @riot-ci @mguetschow @benpicco