Skip to content

pkg/mpaland-printf: Add missing wrapper for fputs#21889

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
maribu:pkg/mpaland-printf/wrap-fputs
Nov 17, 2025
Merged

pkg/mpaland-printf: Add missing wrapper for fputs#21889
benpicco merged 1 commit intoRIOT-OS:masterfrom
maribu:pkg/mpaland-printf/wrap-fputs

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Nov 17, 2025

Contribution description

Another endpoint that was forgotten to overwrite. This fixes the output of the i2c_scan shell command that is e.g. included in the test app in tests/periph/i2c.

Testing procedure

In master

$ make BOARD=same54-xpro -C tests/periph/i2c flash term
make: Entering directory '/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c'
Building application "tests_i2c" for "same54-xpro" with CPU "samd5x".
   text	  data	   bss	   dec	   hex	filename
  24500	   172	  2844	 27516	  6b7c	/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c/bin/same54-xpro/tests_i2c.elf
[...]
> i2c_scan 0
2025-11-17 20:36:56,633 # i2c_scan 0
2025-11-17 20:36:56,636 # Scanning I2C device 0...
2025-11-17 20:36:56,642 # addr not ack'ed = "-", addr ack'ed = "X", addr reserved = "R", error = "E"
2025-11-17 20:36:56,645 #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2025-11-17 20:36:56,646 # 
2025-11-17 20:36:56,648 # 
2025-11-17 20:36:56,650 # 
2025-11-17 20:36:56,652 # 
2025-11-17 20:36:56,654 # 
2025-11-17 20:36:56,656 # 
2025-11-17 20:36:56,657 # 
2025-11-17 20:36:56,658 # 
> i2c_scan 0
2025-11-17 20:37:00,096 # 0x00 R R R R R R R R - - - - - - - -0x10 - - - - - - - - - - - - - - - -0x20 - - - - - - - - - - - - - - - -0x30 - - - - - - - - - - - - - - - -0x40 - - - - - - - - - - - - - - - -0x50 - - - - - - - - - - - - - - - -0x60 - - - - - - - - - - - - - - - -0x70 - - - - - - - - R R R R R R R Ri2c_scan 0
2025-11-17 20:37:00,098 # Scanning I2C device 0...
2025-11-17 20:37:00,104 # addr not ack'ed = "-", addr ack'ed = "X", addr reserved = "R", error = "E"
2025-11-17 20:37:00,107 #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2025-11-17 20:37:00,108 # 
2025-11-17 20:37:00,110 # 
2025-11-17 20:37:00,112 # 
2025-11-17 20:37:00,114 # 
2025-11-17 20:37:00,116 # 
2025-11-17 20:37:00,118 # 
2025-11-17 20:37:00,120 # 
2025-11-17 20:37:00,121 #

This PR

$ make BOARD=same54-xpro -C tests/periph/i2c flash term
make: Entering directory '/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c'
Building application "tests_i2c" for "same54-xpro" with CPU "samd5x".
[...]
   text	  data	   bss	   dec	   hex	filename
  24132	   172	  2844	 27148	  6a0c	/home/[email protected]/Repos/software/RIOT/master/tests/periph/i2c/bin/same54-xpro/tests_i2c.elf
[...]
> i2c_scan 0
2025-11-17 20:35:12,668 # i2c_scan 0
2025-11-17 20:35:12,670 # Scanning I2C device 0...
2025-11-17 20:35:12,677 # addr not ack'ed = "-", addr ack'ed = "X", addr reserved = "R", error = "E"
2025-11-17 20:35:12,680 #      0 1 2 3 4 5 6 7 8 9 a b c d e f
2025-11-17 20:35:12,684 # 0x00 R R R R R R R R - - - - - - - -
2025-11-17 20:35:12,689 # 0x10 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,694 # 0x20 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,698 # 0x30 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,703 # 0x40 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,708 # 0x50 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,713 # 0x60 - - - - - - - - - - - - - - - -
2025-11-17 20:35:12,717 # 0x70 - - - - - - - - R R R R R R R R

Issues/PRs references

None

@maribu
pkg/mpaland-printf: Add missing wrapper for fputs
b67daab 
Another endpoint that was forgotten to overwrite. This fixes the
output of the `i2c_scan` shell command that is e.g. included in the
test app in `tests/periph/i2c`.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 17, 2025
@github-actions github-actions bot added the Area: pkg Area: External package ports label Nov 17, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Nov 17, 2025

Murdock results

✔️ PASSED

b67daab pkg/mpaland-printf: Add missing wrapper for fputs

Success Failures Total Runtime
10932 0 10932 09m:40s

Artifacts

@benpicco benpicco enabled auto-merge November 17, 2025 20:14
@benpicco benpicco added this pull request to the merge queue Nov 17, 2025
Merged via the queue into RIOT-OS:master with commit 298f722 Nov 17, 2025
29 checks passed
@maribu maribu deleted the pkg/mpaland-printf/wrap-fputs branch November 18, 2025 05:01
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Nov 18, 2025

Thx ❤️

@maribu maribu mentioned this pull request Nov 18, 2025
Merged
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Nov 18, 2025

Backport provided in #21892

@leandrolanzieri leandrolanzieri added this to the Release 2025.10 milestone Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2026.01

Development

Successfully merging this pull request may close these issues.

4 participants

@maribu @riot-ci @benpicco @leandrolanzieri