drivers/motor_driver: fix accidental braking#21847
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Nov 5, 2025
Merged
Conversation
crasbe
added
Type: bug
Contributor
|
Ping @gdoffe :) |
Contributor
|
Hi, @LeonardHerbst good catch ! I totally agree with the fix. 👍 |
Contributor
Author
Glad to help. And thanks for giving the motor driver an overhaul. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When the motor driver mode is set to
MOTOR_DRIVER_2_DIRS, the states of theDIR0andDIR1pins encode both the rotation direction and whether the motor should brake."Removing" the brakes causes both pins to be set to the inverse of the braking state. So, if the driver is configured to brake high, both pins will be set low, and vice versa. Most H-bridges will break both in the low and high state.
I also adjusted the phrasing in the documentation a bit.