cpu/sam0_common: clear tamper wake on gpio_irq_disable()#21846
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Nov 7, 2025
Merged
cpu/sam0_common: clear tamper wake on gpio_irq_disable()#21846crasbe merged 1 commit intoRIOT-OS:masterfrom
gpio_irq_disable()#21846crasbe merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
changed the title
gpio_irq_disable()
github-actions
bot
added
Platform: ARM
crasbe
reviewed
Nov 5, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
Unfortunately I don't have any SAM hardware, so I can't test it.
| return 0; | ||
| } | ||
|
|
||
| int rtc_tamper_pin_enable(gpio_t pin) |
Contributor
There was a problem hiding this comment.
Would it make sense to use this function for rtc_tamper_register? That would reduce duplicate code.
Contributor
Author
There was a problem hiding this comment.
That would result in +/- 0 lines since only the line setting the bit could be shared.
crasbe
added
Type: enhancement
benpicco
force-pushed
the
cpu/sam0-gpio_tamper
branch
from
cfad137 to
c5426df
Compare
benpicco
force-pushed
the
cpu/sam0-gpio_tamper
branch
from
c5426df to
15ffad4
Compare
maribu
approved these changes
Nov 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
We register the tamper pin in
gpio_init_int(), so also disable it ingpio_irq_disable()(and re-enable it ingpio_irq_enable()).Testing procedure
Issues/PRs references