pkg: Always add mandatory GITAMFLAGS#21841
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Nov 3, 2025
Merged
Conversation
We really don't want a `make BOARD=some-board -C some/app` to ask for a password to unlock a GPG key. That is more than confusing on a desktop machine and a real pain on a headless device.
github-actions
bot
added
Area: build system
maribu
added
Type: bug
crasbe
approved these changes
Nov 3, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
I did not test it locally, but the changes look simple enough and arduino_api is the only package that has this issue.
Member
Author
|
@benpicco: Do you want this backported? I'd say this bug is not too urgent. |
Member
Author
|
Backport provided in #21879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
We really don't want a
make BOARD=some-board -C some/appto ask for a password to unlock a GPG key. That is more than confusing on a desktop machine and a real pain on a headless device.Hence, this adds the mandatory part of
GITAMFLAGSwith a+=rather than a?=.Testing procedure
E.g. remove
pkg/arduino_apifrom your$(BUILD_DIR), runmake BOARD=nucleo-f767zi -C tests/pkg/arduino_sdi_12 -j. Then inside$(BUILD_DIR)/pkg/arduino_apirungit verify-commit HEAD.In
master, this will state a valid signature, with this PR it will fail due to absense of a signature.Issues/PRs references
None