Skip to content

pkg: Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to cmake flags#21839

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:pkg/cmake/fix-compilation-on-cmake-4.1.2
Nov 3, 2025
Merged

pkg: Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to cmake flags#21839
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:pkg/cmake/fix-compilation-on-cmake-4.1.2

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Nov 2, 2025

Contribution description

This disable policy enforcement of newer cmake 4.1.2 on older cmake projects. The flags can be removed once the upstream projects are compatible with newer versions of cmake.

Testing procedure

  • Green CI
  • Compilation with cmake 4.1.2 (e.g. Alpine Edge) no longer fails for the following apps
    • examples/lang_support/community/javascript
    • tests/pkg/nimble_autoconn_ccnl
    • tests/pkg/cryptoauthlib_internal-tests
    • tests/pkg/cryptoauthlib_compare_sha256
    • examples/networking/misc/openthread
    • examples/networking/misc/ccn-lite-relay

Issues/PRs references

None

@maribu maribu requested a review from jia200x as a code owner November 2, 2025 22:24
@github-actions github-actions bot added Area: network Area: Networking Area: pkg Area: External package ports labels Nov 2, 2025
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 2, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Nov 2, 2025 •
edited
Loading

Murdock results

✔️ PASSED

5305a12 pkg: Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to cmake flags

Success Failures Total Runtime
10553 0 10557 12m:34s

Artifacts

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Nov 3, 2025

The flags can be removed once the upstream projects are compatible with newer versions of cmake.

Perhaps you can add a comment to the Makefiles so that we won't forget?

@maribu @crasbe
pkg: Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to cmake flags
5305a12 
This disable policy enforcement of newer cmake 4.1.2 on older cmake
projects. The flags can be removed once the upstream projects are
compatible with newer versions of cmake.

Co-authored-by: crasbe <[email protected]>
@maribu maribu force-pushed the pkg/cmake/fix-compilation-on-cmake-4.1.2 branch from f932883 to 5305a12 Compare November 3, 2025 09:02
@crasbe crasbe enabled auto-merge November 3, 2025 09:04
@crasbe crasbe added this pull request to the merge queue Nov 3, 2025
@crasbe crasbe added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Nov 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2025
@maribu maribu added this pull request to the merge queue Nov 3, 2025
Merged via the queue into RIOT-OS:master with commit 5d26414 Nov 3, 2025
27 checks passed
@maribu maribu deleted the pkg/cmake/fix-compilation-on-cmake-4.1.2 branch November 6, 2025 09:24
@maribu maribu mentioned this pull request Nov 6, 2025
Merged
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Nov 6, 2025

Backport provided in #21851

@leandrolanzieri leandrolanzieri added this to the Release 2026.01 milestone Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crasbe crasbe crasbe approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

No one assigned

Labels

Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2026.01

Development

Successfully merging this pull request may close these issues.

4 participants

@maribu @riot-ci @crasbe @leandrolanzieri