Skip to content

cpu/esp_common: make Xtensa ISR_STACKSIZE conditional#21832

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
crasbe:pr/xtensa_isr_stacksize
Oct 30, 2025
Merged

cpu/esp_common: make Xtensa ISR_STACKSIZE conditional#21832
benpicco merged 1 commit intoRIOT-OS:masterfrom
crasbe:pr/xtensa_isr_stacksize

Conversation

@crasbe
Copy link
Copy Markdown
Contributor

@crasbe crasbe commented Oct 30, 2025

Contribution description

The Xtensa CPU architecture is currently the only one that defines the ISR_STACKSIZE unconditionally, which leads to issues when an application wants to define that stacksize.

Testing procedure

This should not have any effects and the CI should build as expected.

Issues/PRs references

Discovered in #21206.

@crasbe crasbe requested a review from gschorcht as a code owner October 30, 2025 12:48
@github-actions github-actions bot added Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Oct 30, 2025
@crasbe crasbe added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 30, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 30, 2025

Murdock results

✔️ PASSED

f7628d8 cpu/esp_common: make Xtensa ISR_STACKSIZE conditional

Success Failures Total Runtime
10560 0 10560 09m:37s

Artifacts

@benpicco benpicco enabled auto-merge October 30, 2025 13:06
@benpicco benpicco added this pull request to the merge queue Oct 30, 2025
Merged via the queue into RIOT-OS:master with commit 258b48d Oct 30, 2025
29 checks passed
@crasbe crasbe deleted the pr/xtensa_isr_stacksize branch October 30, 2025 16:02
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants