examples/networking/gnrc: remove gnrc prefix from folder names#21826
examples/networking/gnrc: remove gnrc prefix from folder names#21826mguetschow merged 4 commits intoRIOT-OS:masterfrom
Conversation
There was a problem hiding this comment.
I grepped the sourcetree and accidentally found a lot of paths that are already incorrect:
cbuec@W11nMate:~/RIOTstuff/riot-guides/RIOT$ grep -Rnw . -e "networking/gnrc_.*"
./examples/networking/misc/lwm2m/README.md:92:[border router](https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc_border_router).
./examples/networking/coap/gcoap/README-slip.md:67:[1]: https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc_border_router "SLIP instructions"
./examples/advanced/suit_update/README.hardware.md:87:[gnrc_border_router](https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc_border_router)
./examples/advanced/suit_update/README.hardware.md:90: $ make BOARD=<BR board> -C examples/networking/gnrc_border_router flash
Edit: obsolete.
But with the right command I found a lot more correct paths that have to be migrated:
cbuec@W11nMate:~/RIOTstuff/riot-guides/RIOT$ grep -Rnw . -e "networking/gnrc/gnrc_.*"
./dist/tools/zep_dispatch/README.md:120: USEMODULE=gnrc_rpl make -C examples/networking/gnrc/gnrc_border_router all term
./dist/tools/zep_dispatch/README.md:152: USE_ZEP=1 make -C examples/networking/gnrc/gnrc_networking all term
./dist/tools/zep_dispatch/README.md:153: USE_ZEP=1 make -C examples/networking/gnrc/gnrc_networking all term
./dist/tools/dhcpv6-pd_ia/README.md:25:[`gnrc_border_router` example]: ../../../examples/networking/gnrc/gnrc_border_router
./dist/tools/desvirt/README.desvirt.md:88:riotnative : Start the RIOT: socat EXEC:'/home/pschmerzl/RIOT/examples/networking/gnrc/gnrc_networking/bin/native/gnrc_networking.elf line4_1',end-close,stderr,pty TCP-L:4711,reuseaddr,fork
./dist/tools/desvirt/README.desvirt.md:91:riotnative : Start the RIOT: socat EXEC:'/home/pschmerzl/RIOT/examples/networking/gnrc/gnrc_networking/bin/native/gnrc_networking.elf line4_0',end-close,stderr,pty TCP-L:4712,reuseaddr,fork
./dist/tools/desvirt/README.desvirt.md:94:riotnative : Start the RIOT: socat EXEC:'/home/pschmerzl/RIOT/examples/networking/gnrc/gnrc_networking/bin/native/gnrc_networking.elf line4_3',end-close,stderr,pty TCP-L:4713,reuseaddr,fork
./dist/tools/desvirt/README.desvirt.md:97:riotnative : Start the RIOT: socat EXEC:'/home/pschmerzl/RIOT/examples/networking/gnrc/gnrc_networking/bin/native/gnrc_networking.elf line4_2',end-close,stderr,pty TCP-L:4714,reuseaddr,fork
./dist/tools/vagrant/freebsd/README.md:42:make -C examples/networking/gnrc/gnrc_networking all -j16
./dist/tools/vagrant/freebsd/README.md:43:make -C examples/networking/gnrc/gnrc_networking term
./cpu/esp32/doc.md:1691:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./cpu/esp32/doc.md:1748:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./cpu/esp32/doc.md:1800:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./cpu/esp8266/doc.md:721:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./cpu/esp8266/doc.md:772:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./cpu/esp_common/esp-wifi/doc.md:49:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./cpu/esp_common/esp-wifi/doc.md:100:make -C examples/networking/gnrc/gnrc_networking BOARD=...
./doc/guides/getting-started/building_example.mdx:72:make -C examples/networking/gnrc/gnrc_networking/ term \
./doc/starlight/src/content/docs/getting-started/building_example.mdx:72:make -C examples/networking/gnrc/gnrc_networking/ term \
./examples/networking/gnrc/border_router/README.md:126:For instance, if you use the [`gnrc_networking`](https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc/gnrc_networking) example on the mote, you can
./examples/networking/coap/gcoap/README.md:96:[2]: https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc/gnrc_networking "instructions"
./examples/networking/coap/gcoap/README.md:97:[3]: https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc/gnrc_border_router "SLIP instructions"
./examples/README.md:101:| [gnrc_minimal](./networking/gnrc/gnrc_minimal/README.md) | This is a minimalistic example for RIOT's gnrc network stack. |
./examples/README.md:102:| [gnrc_networking](./networking/gnrc/gnrc_networking/README.md) | This example demonstrates the usage of the GNRC network stack in RIOT. |
./examples/README.md:103:| [gnrc_networking_subnets](./networking/gnrc/gnrc_networking_subnets/README.md) | This example demonstrates IPv6 subnet auto-configuration for networks on a tree topology. |
./examples/README.md:104:| [gnrc_border_router](./networking/gnrc/gnrc_border_router/README.md) | Example of `gnrc_border_router` using automatic configuration |
./examples/README.md:105:| [gnrc_lorawan](./networking/gnrc/gnrc_lorawan/README.md) | Send and receive LoRaWAN packets and perform basic LoRaWAN commands |
./pkg/nimble/README.ipv6-over-ble.md:28:First, you compile and flash the `examples/networking/gnrc/gnrc_networking` application to your
./tests/net/gnrc_sixlowpan_frag_sfr_congure_impl/README.md:8:[1]: https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc/gnrc_networking
./tests/net/gnrc_udp/README.md:11:[1]: https://github.com/RIOT-OS/RIOT/tree/master/examples/networking/gnrc/gnrc_networking
./tests/riotboot_flashwrite/README.md:30: $ BOARD=<board> make -C examples/networking/gnrc/gnrc_border_router flash
./boards/feather-m0/doc.md:69: make BOARD=feather-m0-wifi -C examples/networking/gnrc/gnrc_networking
./boards/feather-m0/doc.md:83:make BOARD=feather-m0-lora -C examples/networking/gnrc/gnrc_lorawan
./boards/openlabs-kw41z-mini/doc.md:60: cd RIOT/examples/networking/gnrc/gnrc_networking
./drivers/doc.txt:160: * USEMODULE=shield_w5100 make BOARD=arduino-due -C examples/networking/gnrc/gnrc_networking
./drivers/atwinc15x0/doc.txt:171:make BOARD=... -C examples/networking/gnrc/gnrc_networking flash term
Perhaps you can migrate the four incorrect paths too. |
|
Found some more: |
|
The applications do keep their names, only the folders got renamed from |
|
That would leave this one: Although that looks more like a copy&paste error and should probably be Edit: While at it, I don't know why the README mentions the |
crasbe
left a comment
There was a problem hiding this comment.
Soft-ACK, although I'd like to get a second opinion perhaps from @AnnsAnns and/or @mguetschow who did work on the example migration.
mguetschow
left a comment
There was a problem hiding this comment.
Good idea, I've also been slightly annoyed by this before. Haven't tested and grepped for missing parts myself, but trusting you too on this :)
Contribution description
Since the directory restuturing it has always annoyed me having to type
gnrc/gnrc_networking.Remove the
gnrc_prefix from folders that are already in thegnrc/folder, so now typinggnrc/networkingis much more tab-completion friendly.Testing procedure
Only renaming, CI should spot hard-coded paths.
Issues/PRs references