Skip to content

dist/tools: add knob for docker pinning test#21815

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:dist/tools/buildsystem_sanity_check/add-knob-for-docker-pinning-test
Oct 23, 2025
Merged

dist/tools: add knob for docker pinning test#21815
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:dist/tools/buildsystem_sanity_check/add-knob-for-docker-pinning-test

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Oct 23, 2025

Contribution description

Allow to opt out of the docker pinning test using

ENABLE_DOCKER_PINNING_TEST=0 make static-test

The intended user is the CI for the docker image test.

Testing procedure

Mess up the docker image digit, e.g.

--- a/makefiles/docker.inc.mk
+++ b/makefiles/docker.inc.mk
@@ -5,7 +5,7 @@
 # When the docker image is updated, checks at
 # dist/tools/buildsystem_sanity_check/check.sh start complaining in CI, and
 # provide the latest values to verify and fill in.
-DOCKER_TESTED_IMAGE_REPO_DIGEST := 21c416fbbb94a99c3d9c76341baf5a9740608b1d1af89967127c7a171248fd7b
+DOCKER_TESTED_IMAGE_REPO_DIGEST := 21c416fbbb94a99c3d9c76341baf5a9740608b1d1af89967127c7a171248fd7c
 
 DOCKER_PULL_IDENTIFIER := docker.io/riot/riotbuild@sha256:$(DOCKER_TESTED_IMAGE_REPO_DIGEST)
 export DOCKER_IMAGE ?= $(DOCKER_PULL_IDENTIFIER)

The static tests should fail if invoked via:

  • ENABLE_DOCKER_PINNING_TEST=1 make static-test
  • make static test

And should pass despite the incorrect digit when invoked via

  • ENABLE_DOCKER_PINNING_TEST=0 make static-test

Issues/PRs references

None

@maribu
dist/tools: add knob for docker pinning test
de16690 
Allow to opt out of the docker pinning test using

    ENABLE_DOCKER_PINNING_TEST=0 make static-test

The intended user is the CI for the docker image test.
@maribu maribu added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components labels Oct 23, 2025
@github-actions github-actions bot added Area: tools Area: Supplementary tools and removed Area: CI Area: Continuous Integration of RIOT components labels Oct 23, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 23, 2025

Murdock results

✔️ PASSED

de16690 dist/tools: add knob for docker pinning test

Success Failures Total Runtime
1 0 1 01m:17s

Artifacts

mguetschow
mguetschow approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that'll make Dockerfile bumps easier in the future :)

@maribu maribu enabled auto-merge October 23, 2025 08:39
@maribu maribu added this pull request to the merge queue Oct 23, 2025
Merged via the queue into RIOT-OS:master with commit 8409274 Oct 23, 2025
29 checks passed
@maribu maribu deleted the dist/tools/buildsystem_sanity_check/add-knob-for-docker-pinning-test branch October 23, 2025 08:47
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees

No one assigned

Labels

Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2025.10

Development

Successfully merging this pull request may close these issues.

4 participants

@maribu @riot-ci @mguetschow @benpicco