Skip to content

ci/docs: Build/Deploy on changes to outside text#21810

Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom
AnnsAnns:build_on_md_changes
Oct 21, 2025
Merged

ci/docs: Build/Deploy on changes to outside text#21810
crasbe merged 1 commit intoRIOT-OS:masterfrom
AnnsAnns:build_on_md_changes

Conversation

@AnnsAnns
Copy link
Copy Markdown
Member

@AnnsAnns AnnsAnns commented Oct 20, 2025

Contribution description

Currently changes to text files used by starlight that are outside the docs folder will not be picked up by the CI. While usually this should be relatively rare, given that these files aren't touched that much, esp. in the case of releases this could be quite annoying because the release changelog would not trigger a rebuild of the guide site, thus not updating the changelog till a random change is made within the doc folder.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Oct 20, 2025
@AnnsAnns AnnsAnns added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Oct 20, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 20, 2025

Murdock results

✔️ PASSED

0c2a85f ci/docs: Build/Deploy on changes to outside text

Success Failures Total Runtime
1 0 1 01m:09s

Artifacts

Copy link
Copy Markdown
Member

@LasseRosenow LasseRosenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (@AnnsAnns != window.writingBachelorThesis()) {
    throw new Error("Sie prokrastinieren doch!")
}

@crasbe crasbe enabled auto-merge October 21, 2025 11:13
@crasbe crasbe added this pull request to the merge queue Oct 21, 2025
Merged via the queue into RIOT-OS:master with commit c99a260 Oct 21, 2025
30 checks passed
@AnnsAnns
Copy link
Copy Markdown
Member Author

AnnsAnns commented Oct 22, 2025

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Oct 22, 2025

But the CODING_CONVENTIONS_C++.md file was only added in this PR.

@AnnsAnns
Copy link
Copy Markdown
Member Author

AnnsAnns commented Oct 22, 2025

Yeah thats what I dont really understand right now, its saying its using that script but the error would only happen on this script

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Oct 22, 2025

The reason is probably that the PR not based on the latest master. When I synced my crasbe/RIOT/master branch to upstream, I got another two e-mails.

https://github.com/crasbe/RIOT/actions/runs/18727783986
https://github.com/crasbe/RIOT/actions/runs/18727783730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants