Skip to content

doc: deprecate Doxygen Getting Started and add CoAP guide#21792

Merged
AnnsAnns merged 4 commits intoRIOT-OS:masterfrom
LasseRosenow:doxygen-deprecate-getting-started
Oct 15, 2025
Merged

doc: deprecate Doxygen Getting Started and add CoAP guide#21792
AnnsAnns merged 4 commits intoRIOT-OS:masterfrom
LasseRosenow:doxygen-deprecate-getting-started

Conversation

@LasseRosenow
Copy link
Copy Markdown
Member

@LasseRosenow LasseRosenow commented Oct 13, 2025

Contribution description

This deprecates the remaining sections in the Getting started page of the old doxygen docs.

This also adds a new CoAP guide, but this one is still WIP especially regarding the code testing part.

This also added support to the code_checker of the guides to check files in subfolders. I needed this for the new coap guide, which comes with a server and a client application.

@github-actions github-actions bot added Area: doc Area: Documentation Area: examples Area: Example Applications labels Oct 13, 2025
@LasseRosenow LasseRosenow force-pushed the doxygen-deprecate-getting-started branch 3 times, most recently from 2b8d906 to c6ad698 Compare October 13, 2025 20:55
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Oct 13, 2025
@LasseRosenow LasseRosenow marked this pull request as ready for review October 13, 2025 21:06
@LasseRosenow
Copy link
Copy Markdown
Member Author

This is ready for review now.
I hope this is the last time for the coming future that we need to push package-lock.json files without adding new packages.
I have changed the install script to use npm ci which does not modify the package-lock.json, but needs the package-lock.json to be "in-sync" with the package.json.
The state was, that it was not in-sync, so I needed to run npm install once more, so that it is in a good state now.

@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 13, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 13, 2025

Murdock results

✔️ PASSED

d69396e dist/tools/code_in_guides_check: support subfolders

Success Failures Total Runtime
37 0 37 01m:48s

Artifacts

Copy link
Copy Markdown
Contributor

@crasbe crasbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some static errors about missing copyright notices and long lines, please check that at your own discretion :)

@crasbe crasbe changed the title Doxygen deprecate getting started and add CoAP guide doc: deprecate Doxygen Getting Started and add CoAP guide Oct 13, 2025
@LasseRosenow
Copy link
Copy Markdown
Member Author

LasseRosenow commented Oct 14, 2025

Thank you for your review :) I addressed everything except the points that need further clarification/discussion :)

Copy link
Copy Markdown
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You guys live in the same timezone as me why are you both doing stuff at 1am 😨 (Small nitpicks)

@LasseRosenow
Copy link
Copy Markdown
Member Author

LasseRosenow commented Oct 14, 2025

You guys live in the same timezone as me why are you both doing stuff at 1am 😨 (Small nitpicks)

I was deep asleep at 1am lol wuat? 😲

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Oct 14, 2025

You guys live in the same timezone as me why are you both doing stuff at 1am 😨

Watching Starship Launch 11 🚀

@LasseRosenow
Copy link
Copy Markdown
Member Author

LasseRosenow commented Oct 14, 2025

Watching Starship Launch 11 🚀

Did it at least crash into some famous billionaires home?

@LasseRosenow
Copy link
Copy Markdown
Member Author

All reviews addressed (I hope)

@AnnsAnns
Copy link
Copy Markdown
Member

You guys live in the same timezone as me why are you both doing stuff at 1am 😨

Watching Starship Launch 11 🚀

Damn, you should work on space tech or something /s

Copy link
Copy Markdown
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work on this, we finally have a guide for the one section we were really missing 😄 (And 🦀 doxygen guides are dead 🦀 )

(Squashable from my POV but wait for crasbe/mguetschow pls)

Copy link
Copy Markdown
Contributor

@crasbe crasbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a smöl thing, let's wait for @mguetschow too though.

@AnnsAnns
Copy link
Copy Markdown
Member

Looks like he reacted with a 🚀 to his review. (Also, 3 Acks? Quick, rewrite the core of RIOT in Rust while you can and nobody notices /s)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Oct 15, 2025

Let me run make generate-Makefile.ci for your two new examples real quick.

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Oct 15, 2025

Client:

buechse@skyleaf:~/RIOTstuff/riot-release/RIOT/examples/guides/coap$ cat client/Makefile.ci
BOARD_INSUFFICIENT_MEMORY := \
    arduino-duemilanove \
    arduino-leonardo \
    arduino-mega2560 \
    arduino-nano \
    arduino-uno \
    atmega328p \
    atmega328p-xplained-mini \
    atmega8 \
    bluepill-stm32f030c8 \
    i-nucleo-lrwan1 \
    msb-430 \
    msb-430h \
    nucleo-c031c6 \
    nucleo-f030r8 \
    nucleo-f031k6 \
    nucleo-f042k6 \
    nucleo-f303k8 \
    nucleo-f334r8 \
    nucleo-l011k4 \
    nucleo-l031k6 \
    nucleo-l053r8 \
    olimex-msp430-h1611 \
    olimex-msp430-h2618 \
    samd10-xmini \
    slstk3400a \
    stk3200 \
    stm32f030f4-demo \
    stm32f0discovery \
    stm32g0316-disco \
    stm32l0538-disco \
    telosb \
    weact-g030f6 \
    z1 \
    #

Server:

buechse@skyleaf:~/RIOTstuff/riot-release/RIOT/examples/guides/coap$ cat server/Makefile.ci
BOARD_INSUFFICIENT_MEMORY := \
    arduino-duemilanove \
    arduino-leonardo \
    arduino-mega2560 \
    arduino-nano \
    arduino-uno \
    atmega328p \
    atmega328p-xplained-mini \
    atmega8 \
    bluepill-stm32f030c8 \
    i-nucleo-lrwan1 \
    msb-430 \
    msb-430h \
    nucleo-c031c6 \
    nucleo-f030r8 \
    nucleo-f031k6 \
    nucleo-f042k6 \
    nucleo-f303k8 \
    nucleo-f334r8 \
    nucleo-l011k4 \
    nucleo-l031k6 \
    nucleo-l053r8 \
    olimex-msp430-h1611 \
    samd10-xmini \
    slstk3400a \
    stk3200 \
    stm32f030f4-demo \
    stm32f0discovery \
    stm32g0316-disco \
    stm32l0538-disco \
    telosb \
    weact-g030f6 \
    z1 \
    #

@LasseRosenow
Copy link
Copy Markdown
Member Author

LasseRosenow commented Oct 15, 2025

Thank you, I added them :)

@crasbe crasbe removed the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Oct 15, 2025
@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Oct 15, 2025

You can squash that directly.

Co-authored-by: crasbe <[email protected]>
Co-authored-by: Ann🐸 <[email protected]>
@LasseRosenow LasseRosenow force-pushed the doxygen-deprecate-getting-started branch from 0468dde to 392729f Compare October 15, 2025 12:52
@LasseRosenow
Copy link
Copy Markdown
Member Author

Done

@crasbe crasbe enabled auto-merge October 15, 2025 12:53
@crasbe crasbe added this pull request to the merge queue Oct 15, 2025
Comment on lines 41 to 43
while IFS= read -r -d '' src_file; do
# Read the file content
src_content=$(cat "$src_file")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
while IFS= read -r -d '' src_file; do
# Read the file content
src_content=$(cat "$src_file")
# Exclude `/bin/` folders
INPUT_FILES=$(
find "$SOURCE_DIR" \
-type d -name "bin" -prune\
-or -type f -print\
)
for src_file in "$INPUT_FILES"; do
# Read the file content
src_content=$(cat "$src_file")

Why not like that? Am I missing something that the (for me) obvious solution was not chosen?

I also hate that $SOURCE_DIR is just magically known here...

Copy link
Copy Markdown
Contributor

@Teufelchen1 Teufelchen1 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this wasn't a patch but a hint at an alternative coupled to a question, patching this in broke the script.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@crasbe crasbe removed this pull request from the merge queue due to a manual request Oct 15, 2025
@Teufelchen1
Copy link
Copy Markdown
Contributor

I feel like this should have been two or three PRs.

@LasseRosenow
Copy link
Copy Markdown
Member Author

I applied your patches

Comment on lines +41 to +46
for src_file in "$SOURCE_DIR"/*; do
# Skip if not a regular file
[ -f "$src_file" ] || continue

# Exclude `/bin/` folders
INPUT_FILES=$(
find "$SOURCE_DIR" \
-type d -name "bin" -prune\
-or -type f -print\
)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it appears like the CI fails completely 😅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the GitHub static test is very mad one line below. (Not sure why tho, works on my machine hehehehe)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@LasseRosenow
Copy link
Copy Markdown
Member Author

Okay the script works again

Copy link
Copy Markdown
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 Here we go again

@LasseRosenow LasseRosenow force-pushed the doxygen-deprecate-getting-started branch from c34fab9 to d69396e Compare October 15, 2025 13:41
@AnnsAnns AnnsAnns enabled auto-merge October 15, 2025 13:43
@AnnsAnns AnnsAnns added this pull request to the merge queue Oct 15, 2025
Merged via the queue into RIOT-OS:master with commit e46e3ac Oct 15, 2025
26 checks passed
@LasseRosenow LasseRosenow deleted the doxygen-deprecate-getting-started branch October 15, 2025 13:56
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation Area: examples Area: Example Applications Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants