doc: deprecate Doxygen Getting Started and add CoAP guide#21792
doc: deprecate Doxygen Getting Started and add CoAP guide#21792AnnsAnns merged 4 commits intoRIOT-OS:masterfrom
Getting Started and add CoAP guide#21792Conversation
2b8d906 to
c6ad698
Compare
|
This is ready for review now. |
crasbe
left a comment
There was a problem hiding this comment.
There are some static errors about missing copyright notices and long lines, please check that at your own discretion :)
Getting Started and add CoAP guide
|
Thank you for your review :) I addressed everything except the points that need further clarification/discussion :) |
AnnsAnns
left a comment
There was a problem hiding this comment.
You guys live in the same timezone as me why are you both doing stuff at 1am 😨 (Small nitpicks)
I was deep asleep at 1am lol wuat? 😲 |
Watching Starship Launch 11 🚀 |
Did it at least crash into some famous billionaires home? |
|
All reviews addressed (I hope) |
Damn, you should work on space tech or something /s |
crasbe
left a comment
There was a problem hiding this comment.
Just a smöl thing, let's wait for @mguetschow too though.
|
Looks like he reacted with a 🚀 to his review. (Also, 3 Acks? Quick, rewrite the core of RIOT in Rust while you can and nobody notices /s) |
|
Let me run |
|
Client: Server: |
|
Thank you, I added them :) |
|
You can squash that directly. |
Co-authored-by: crasbe <[email protected]> Co-authored-by: Ann🐸 <[email protected]>
0468dde to
392729f
Compare
|
Done |
| while IFS= read -r -d '' src_file; do | ||
| # Read the file content | ||
| src_content=$(cat "$src_file") |
There was a problem hiding this comment.
| while IFS= read -r -d '' src_file; do | |
| # Read the file content | |
| src_content=$(cat "$src_file") | |
| # Exclude `/bin/` folders | |
| INPUT_FILES=$( | |
| find "$SOURCE_DIR" \ | |
| -type d -name "bin" -prune\ | |
| -or -type f -print\ | |
| ) | |
| for src_file in "$INPUT_FILES"; do | |
| # Read the file content | |
| src_content=$(cat "$src_file") |
Why not like that? Am I missing something that the (for me) obvious solution was not chosen?
I also hate that $SOURCE_DIR is just magically known here...
There was a problem hiding this comment.
Since this wasn't a patch but a hint at an alternative coupled to a question, patching this in broke the script.
|
I feel like this should have been two or three PRs. |
|
I applied your patches |
| for src_file in "$SOURCE_DIR"/*; do | ||
| # Skip if not a regular file | ||
| [ -f "$src_file" ] || continue | ||
|
|
||
| # Exclude `/bin/` folders | ||
| INPUT_FILES=$( | ||
| find "$SOURCE_DIR" \ | ||
| -type d -name "bin" -prune\ | ||
| -or -type f -print\ | ||
| ) |
There was a problem hiding this comment.
Actually, it appears like the CI fails completely 😅
There was a problem hiding this comment.
Also the GitHub static test is very mad one line below. (Not sure why tho, works on my machine hehehehe)
|
Okay the script works again |
Co-authored-by: Teufelchen <[email protected]> Co-authored-by: Ann🐸 <[email protected]>
c34fab9 to
d69396e
Compare
Contribution description
This deprecates the remaining sections in the
Getting startedpage of the old doxygen docs.This also adds a new
CoAPguide, but this one is still WIP especially regarding the code testing part.This also added support to the code_checker of the guides to check files in subfolders. I needed this for the new coap guide, which comes with a server and a client application.