Skip to content

doc/guides: remove toc from managing a release and fix using timers guide#21773

Merged
crasbe merged 2 commits intoRIOT-OS:masterfrom
LasseRosenow:guides-remove-managing-a-release-toc
Oct 10, 2025
Merged

doc/guides: remove toc from managing a release and fix using timers guide#21773
crasbe merged 2 commits intoRIOT-OS:masterfrom
LasseRosenow:guides-remove-managing-a-release-toc

Conversation

@LasseRosenow
Copy link
Copy Markdown
Member

@LasseRosenow LasseRosenow commented Oct 8, 2025

Contribution description

The managing a release guide had its own table of contents even though starlight generates one on the side.
It is the only guide that did this and I think it is not relevant to have it.

I also fixed the heading structure in the using timers tutorial

@github-actions github-actions bot added the Area: doc Area: Documentation label Oct 8, 2025
Copy link
Copy Markdown
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Not much I can review

@crasbe crasbe added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 8, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 8, 2025

Murdock results

✔️ PASSED

152736a doc/guides: fix timers headings

Success Failures Total Runtime
1 0 1 02m:03s

Artifacts

8. [Resources](#8-resources)
9. [Forum Post Templates](#9-forum-post-templates)

## 1. Checklist
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is still necessary to have the "1.", "2." in front of the headline then?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it looks fine, I actually kind of like that in the sidebar since this guide is meant to be followed in that order and compared to other guides the maintainer will probably hop in/out of the guide multiple times

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with AnnsAnn, I think in this case it is quite useful, we are doing a similar thing with the c tutorials or c basics, where we say "step 1" "step 2" etc.

Copy link
Copy Markdown
Member Author

@LasseRosenow LasseRosenow Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LasseRosenow
Copy link
Copy Markdown
Member Author

I noticed that the using timers tutorial has two times step 1 in the headings, so I adjusted it so that it is similar to how the other tutorials are structured

@LasseRosenow LasseRosenow changed the title doc/guides: remove toc from managing a release doc/guides: remove toc from managing a release and fix using timers guide Oct 9, 2025
@crasbe crasbe added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 9, 2025
Copy link
Copy Markdown
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for noticing the issue with the timers.md titles 🙇

@crasbe crasbe added this pull request to the merge queue Oct 10, 2025
Merged via the queue into RIOT-OS:master with commit 355e5f4 Oct 10, 2025
30 checks passed
@LasseRosenow LasseRosenow deleted the guides-remove-managing-a-release-toc branch October 10, 2025 09:46
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants