build system: Allow running tests in docker#21752
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Sep 30, 2025
Merged
Conversation
When building for native with `BUILD_IN_DOCKER=1`, the created elf file may not be compatible with the host system if: - The container used is using glibc and the host system is using another C lib - Both container and host are using glibc, but the container is using a more recent one than the host To avoid these issues, this commit changes behavior to just run the `test` goal inside the docker image as well when the board is `native%`.
maribu
added
Type: enhancement
benpicco
approved these changes
Sep 30, 2025
Member
Author
|
Thx ❤️ |
Contributor
|
On my system, commit 651e190 and current
first builds the application locally, then again inside docker and also runs the test inside docker. I think this regression should be fixed before the next release @benpicco. |
maribu
added a commit
to maribu/RIOT
that referenced
this pull request
Oct 14, 2025
Member
Author
|
I can reproduce the issue. I could have sworn it worked as expected when I tested it two weeks ago. See #21793 for the fix. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
…cker-fixup build system: Fix regression from #21752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When building for native with
BUILD_IN_DOCKER=1, the created elf file may not be compatible with the host system if:To avoid these issues, this commit changes behavior to just run the
testgoal inside the docker image as well when the board isnative%.Testing procedure
Run the following commands:
make -C tests/sys/fmt_print all test BOARD=native64 BUILD_IN_DOCKER=1make -C tests/sys/fmt_print all test BOARD=native BUILD_IN_DOCKER=1make -C tests/sys/fmt_print all test BOARD=native64make -C tests/sys/fmt_print all test BOARD=samr21-xpromake -C tests/sys/fmt_print all test BOARD=samr21-xpro BUILD_IN_DOCKER=1Issues/PRs references
None