Skip to content

kinetis/bme: temp disable BITBAND_FUNCTIONS_PROVIDED#21750

Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom
elenaf9:kinetis/bme/temp-disable-bitband-fns
Oct 1, 2025
Merged

kinetis/bme: temp disable BITBAND_FUNCTIONS_PROVIDED#21750
mguetschow merged 1 commit intoRIOT-OS:masterfrom
elenaf9:kinetis/bme/temp-disable-bitband-fns

Conversation

@elenaf9
Copy link
Copy Markdown
Contributor

@elenaf9 elenaf9 commented Sep 30, 2025

Contribution description

The kinetis bme implementation currently doesn't work proberly, see #21705 (comment).
This PR temporarily sets BITBAND_FUNCTIONS_PROVIDED to false so that the default sys/bit implementation for bit manipulation is used instead.

Testing procedure

Issues/PRs references

Came up while extending the bme implementation in #21705.
Unblocks #21577.

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels Sep 30, 2025
@elenaf9 elenaf9 mentioned this pull request Sep 30, 2025
Open
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 30, 2025
@benpicco
Copy link
Copy Markdown
Contributor

benpicco commented Sep 30, 2025

Still needs a

--- a/cpu/kinetis/include/bme.h
+++ b/cpu/kinetis/include/bme.h
@@ -122,6 +123,7 @@ static inline volatile uint8_t *bme_bitfield8(volatile uint8_t *ptr, uint8_t bit
 }
 
 /* For compatibility with the M3/M4 bitbanding macros: */
+#if BITBAND_FUNCTIONS_PROVIDED
 
 /**
  * @brief Set a single bit in the 32 bit word pointed to by @p ptr

to avoid defining those functions twice

@crasbe crasbe added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 30, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Sep 30, 2025 •
edited
Loading

Murdock results

✔️ PASSED

0c7061c kinetis/bme: temp disable BITBAND_FUNCTIONS_PROVIDED

Success Failures Total Runtime
10509 0 10513 11m:07s

Artifacts

@elenaf9 elenaf9 force-pushed the kinetis/bme/temp-disable-bitband-fns branch from 5c4a91e to 3d10d72 Compare September 30, 2025 16:03
@benpicco benpicco enabled auto-merge September 30, 2025 16:05
@benpicco benpicco added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2025
@github-actions github-actions bot added the Area: sys Area: System label Oct 1, 2025
@elenaf9 elenaf9 force-pushed the kinetis/bme/temp-disable-bitband-fns branch from 570e24e to 0c7061c Compare October 1, 2025 07:47
@github-actions github-actions bot added Area: drivers Area: Device drivers and removed Area: sys Area: System labels Oct 1, 2025
@elenaf9
Copy link
Copy Markdown
Contributor Author

elenaf9 commented Oct 1, 2025

Murdock failed in merge queue because some driver didn't include the bit.h (before, it wasn't an issue because the bme.h was implicitly included). Should be fixed now. Could you please requeue?

@elenaf9
kinetis/bme: temp disable BITBAND_FUNCTIONS_PROVIDED
0c7061c 
The kinetis bme currently doesn't work properly. Temporarily disable the
use of the bme so that the default `sys/bit.h` implementation is used
instead.
@mguetschow mguetschow enabled auto-merge October 1, 2025 08:18
@mguetschow mguetschow added this pull request to the merge queue Oct 1, 2025
Merged via the queue into RIOT-OS:master with commit 2562bd6 Oct 1, 2025
25 checks passed
@elenaf9 elenaf9 deleted the kinetis/bme/temp-disable-bitband-fns branch October 1, 2025 18:23
This was referenced Oct 1, 2025
Merged
Merged
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2025.10

Development

Successfully merging this pull request may close these issues.

5 participants

@elenaf9 @benpicco @riot-ci @crasbe @mguetschow