Skip to content

tests/unittests: add test for bit.h#21749

Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco:test/bit
Oct 7, 2025
Merged

tests/unittests: add test for bit.h#21749
benpicco merged 2 commits intoRIOT-OS:masterfrom
benpicco:test/bit

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Sep 29, 2025

Contribution description

This adds unit tests for the functions from bit.h

Testing procedure

Just run make -C tests/unittests tests-bit

Issues/PRs references

depends on #21705

@benpicco benpicco marked this pull request as ready for review September 29, 2025 22:47
@benpicco benpicco requested a review from miri64 as a code owner September 29, 2025 22:47
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: sys Area: System labels Sep 29, 2025
@benpicco benpicco changed the title Test/bit tests/unittests: add test for bit.h Sep 29, 2025
@crasbe crasbe added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 29, 2025
crasbe
crasbe reviewed Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@crasbe crasbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can add a small piece of documentation somewhere explaining what the tests do (except testing bit.h 😅 ).

@riot-ci
Copy link
Copy Markdown

riot-ci commented Sep 29, 2025 •
edited
Loading

Murdock results

✔️ PASSED

ac34cc7 tests/unittests: add test for bit.h

Success Failures Total Runtime
10509 0 10513 13m:29s

Artifacts

@benpicco benpicco force-pushed the test/bit branch 3 times, most recently from 8c718a6 to fd6bd28 Compare September 30, 2025 11:17
crasbe
crasbe reviewed Sep 30, 2025
View reviewed changes
@crasbe crasbe enabled auto-merge September 30, 2025 12:39
@crasbe crasbe added this pull request to the merge queue Sep 30, 2025
@miri64 miri64 removed this pull request from the merge queue due to a manual request Sep 30, 2025
@miri64
Copy link
Copy Markdown
Member

miri64 commented Sep 30, 2025

For some reason the job was stopped https://ci.riot-os.org/details/dc221b39e0a944ea9d9bfd353c3514c8

@miri64 miri64 added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2025
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Oct 6, 2025
@Teufelchen1 Teufelchen1 removed this pull request from the merge queue due to a manual request Oct 6, 2025
@Teufelchen1
Copy link
Copy Markdown
Contributor

Teufelchen1 commented Oct 6, 2025

@benpicco are you aware of the compilation errors in application "tests_unittests" for "frdm-kl43z" (via murdock)?

@elenaf9
Copy link
Copy Markdown
Contributor

elenaf9 commented Oct 6, 2025

@benpicco are you aware of the compilation errors in application "tests_unittests" for "frdm-kl43z" (via murdock)?

I think it's because of #21705, which adds the bit_check_XX functions for the kinetis bme. Right now they don't exist in the bme, and this PR uses them.
In the meantime, however, #21750 has disabled the use of bme temporarily, so it shouldn't be an issue right now that the functions are missing there. I think this PR just needs to be rebased onto current master? (Unless murdock does that already before executing the tests, then I don't know...)

@crasbe crasbe added the State: needs rebase State: The codebase was changed since the creation of the PR, making a rebase necessary label Oct 6, 2025
@benpicco benpicco added this pull request to the merge queue Oct 7, 2025
@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Oct 7, 2025

Murdock already does the rebase before doing the build.

Merged via the queue into RIOT-OS:master with commit 17d03ac Oct 7, 2025
27 checks passed
@benpicco benpicco deleted the test/bit branch October 8, 2025 13:07
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crasbe crasbe crasbe approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees

No one assigned

Labels

Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: needs rebase State: The codebase was changed since the creation of the PR, making a rebase necessary Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2025.10

Development

Successfully merging this pull request may close these issues.

6 participants

@benpicco @riot-ci @miri64 @Teufelchen1 @elenaf9 @crasbe