Skip to content

cpu: move licenses from comments to SPDX format (part3)#21732

Merged
crasbe merged 6 commits intoRIOT-OS:masterfrom
krzysztof-cabaj:cpu_change_to_SPDX_part3
Sep 22, 2025
Merged

cpu: move licenses from comments to SPDX format (part3)#21732
crasbe merged 6 commits intoRIOT-OS:masterfrom
krzysztof-cabaj:cpu_change_to_SPDX_part3

Conversation

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor

@krzysztof-cabaj krzysztof-cabaj commented Sep 20, 2025

Contribution description

This PR moves license information from headers to SPDX format for cpu directory.
In this following cpu's are processed:

  • fe310,
  • gd32v,
  • kinetis,
  • lm4f120,
  • lpc1768/23xx,
  • msp430.

Testing procedure

Review changed files.

Issues/PRs references

Track #21515
Part 1 #21704
Part 2 #21715

@github-actions github-actions bot added Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Sep 20, 2025
@crasbe crasbe added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Sep 21, 2025
@riot-ci
Copy link
Copy Markdown

riot-ci commented Sep 21, 2025 •
edited
Loading

Murdock results

✔️ PASSED

8ab22e3 cpu/msp430: move licenses to SPDX format

Success Failures Total Runtime
1 0 1 01m:24s

Artifacts

crasbe
crasbe requested changes Sep 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@crasbe crasbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's really necessary to change "Universitaet" to "Universität", but it's nice to have more consistency.

Also I don't know what it is about KConfig and the HAW 😅

@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

krzysztof-cabaj commented Sep 22, 2025

All remarks added and squashed to appropriate commits.

In my opinion further global changes to make organization names consistent, should be performed in separate PR and done by organization representative. For example, for mentioned HAW i see in copyrights: HAW Hamburg, Hamburg University of Applied Sciences and even alone HAW in few files ;).

@crasbe
Copy link
Copy Markdown
Contributor

crasbe commented Sep 22, 2025

In my opinion further global changes to make organization names consistent, should be performed in separate PR and done by organization representative. For example, for mentioned HAW i see in copyrights: HAW Hamburg, Hamburg University of Applied Sciences and even alone HAW in few files ;).

I don't think it's worth the effort to actually fix that globally, but the idea was just to have a bit more consistency to make the parsing easier.

@crasbe crasbe added this pull request to the merge queue Sep 22, 2025
Merged via the queue into RIOT-OS:master with commit 283a1e3 Sep 22, 2025
26 checks passed
@krzysztof-cabaj
Copy link
Copy Markdown
Contributor Author

krzysztof-cabaj commented Sep 22, 2025

Thanks for support!

This was referenced Sep 27, 2025
Merged
Merged
@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crasbe crasbe crasbe approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2025.10

Development

Successfully merging this pull request may close these issues.

4 participants

@krzysztof-cabaj @riot-ci @crasbe @benpicco