tests: replace header guards with #pragma once#21702
Merged
crasbe merged 1 commit intoRIOT-OS:masterfrom Sep 8, 2025
Merged
Conversation
N11cc00
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
basilfx,
bergzand,
jeandudey,
jia200x,
jue89,
kaspar030,
leandrolanzieri and
miri64
as code owners
github-actions
bot
added
Area: network
N11cc00
force-pushed
the
fix-tests-headers
branch
from
b0f1e81 to
2983392
Compare
github-actions
bot
removed
Area: network
crasbe
added
Type: cleanup
8 tasks
N11cc00
force-pushed
the
fix-tests-headers
branch
2 times, most recently
from
767a89c to
bdd1590
Compare
Contributor
Author
|
I have changed the script and pushed a new commit. @crasbe |
crasbe
requested changes
Sep 6, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
The script does not seem to work 100% reliably yet. Please go through the files again and check for leftover #defines and double blank linkes. I'm not sure why the one case did not get picked up by the static test.
I did not check all files yet, because it appears like the leftover #defines were kind of a pattern.
N11cc00
force-pushed
the
fix-tests-headers
branch
from
bdd1590 to
90b893b
Compare
Contributor
Author
|
I messed something up with my script. I fixed that bug and now the guards should be replaced correctly. |
crasbe
reviewed
Sep 6, 2025
crasbe
approved these changes
Sep 8, 2025
Contributor
crasbe
left a comment
crasbe
left a comment
There was a problem hiding this comment.
Thanks for fixing all the rest of the files. You can squash the changes now :)
N11cc00
force-pushed
the
fix-tests-headers
branch
from
fb6d870 to
9d01323
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This is part of a greater effort to replace all header guards in RIOT with
#pragma once. This PR only affects all headers undertests/, excluding those that have a path that contains/vendor/.It should now remove double empty lines around the
#ifndefblock.Issues/PRs references
Tracking issue #21335