pkg/mpaland-printf: format points like glibc#21678
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Aug 22, 2025
Merged
Conversation
newlib and picolibc already implicitly add the `0x` prefix for `%p` just as glibc does, and some of our tests scripts depend on this. (And subjectively, this looks better.) This adds mpaland/printf#90 on top of our patches.
Contributor
|
Maybe you can ping the devs in the |
Member
Author
|
Yes, sadly. But the test suite is actually pretty extensive, so I think we might have already caught all relevant unfixed bugs with our set of patches. |
Contributor
|
Don't jinx it 🤣 |
benpicco
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
newlib and picolibc already implicitly add the
0xprefix for%pjust as glibc does, and some of our tests scripts depend on this.(And subjectively, this looks better.)
This adds mpaland/printf#90 on top of our patches.
Testing procedure
Combined with
The failing test in the nightly should pass again
Issues/PRs references